Re: [PATCH] ethtool: FLOW_EXT may confuse drivers

[Ben Hutchings <bhutchings@solarflare.com>]

Please send ethtool patches directly to me as well as to netdev.

On Fri, 2011-05-13 at 10:19 -0400, Sebastian.Poehn@Belden.com wrote:
> The FLOW_EXT bit must be masked out. Otherwise if e.g. vlan is set a
> driver receiving the ntuple may not detect the flow_type correctly!
> 
> Signed-off-by: Sebastian Poehn <sebastian.poehn@belden.com>
> 
> diff --git a/ethtool.c b/ethtool.c
> index 34fe107..0b7ec05 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -3134,6 +3134,9 @@ static int flow_spec_to_ntuple(struct ethtool_rx_flow_spec *fsp,
>                  (u64)ntohl(~fsp->m_ext.data[1]);
>          }
>      }
> +    
> +    /*Mask out the extended bit, because ntuple does not know it!*/
> +    ntuple->flow_type &= ~FLOW_EXT;
>  
>      return 0;
>  }
> 
> DISCLAIMER:
> 
> Privileged and/or Confidential information may be contained in this
> message. If you are not the addressee of this message, you may not
> copy, use or deliver this message to anyone. In such event, you
> should destroy the message and kindly notify the sender by reply
> e-mail. It is understood that opinions or conclusions that do not
> relate to the official business of the company are neither given
> nor endorsed by the company.

I am not the addressee, so I won't apply this (even though it looks
right).  Please get rid of this disclaimer on messages to public mailing
lists.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.