From: Eric Dumazet <eric.dumazet@gmail.com>
To: TB <lkml@techboom.com>, David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: kernel BUG at net/ipv4/tcp_output.c:1006!
Date: Fri, 13 May 2011 21:47:38 +0200 [thread overview]
Message-ID: <1305316058.3120.6.camel@edumazet-laptop> (raw)
In-Reply-To: <4DCD86C0.9030904@techboom.com>
Le vendredi 13 mai 2011 à 15:30 -0400, TB a écrit :
> On 11-05-13 01:27 PM, Eric Dumazet wrote:
> > Le vendredi 13 mai 2011 à 13:11 -0400, TB a écrit :
> >> This is the 2.6.38.5 kernel with the patch in
> >> [PATCH] tcp_cubic: limit delayed_ack ratio to prevent divide error
> >>
> >
> > Please send us full disassembly of tcp_fragment (from vmlinux file)
>
>
> GCC is debian 4.3.2-1.1
> AS 2.18.0.20080103
>
> CPU is Intel Xeon E5620
> Kernel CPU is set to MCORE2 (Core 2/newer Xeon)
>
>
> ffffffff814e7eb0 <tcp_fragment>:
> ffffffff814e7eb0: 41 57 push %r15
> ffffffff814e7eb2: 49 89 ff mov %rdi,%r15
> ffffffff814e7eb5: 41 56 push %r14
> ffffffff814e7eb7: 41 55 push %r13
> ffffffff814e7eb9: 41 89 d5 mov %edx,%r13d
> ffffffff814e7ebc: 41 54 push %r12
> ffffffff814e7ebe: 55 push %rbp
> ffffffff814e7ebf: 53 push %rbx
> ffffffff814e7ec0: 48 89 f3 mov %rsi,%rbx
> ffffffff814e7ec3: 48 83 ec 18 sub $0x18,%rsp
> ffffffff814e7ec7: 89 4c 24 0c mov %ecx,0xc(%rsp)
> ffffffff814e7ecb: 8b 6e 68 mov 0x68(%rsi),%ebp
> ffffffff814e7ece: 39 ea cmp %ebp,%edx
> ffffffff814e7ed0: 76 04 jbe ffffffff814e7ed6
> <tcp_fragment+0x26>
> ffffffff814e7ed2: 0f 0b ud2a
> ffffffff814e7ed4: eb fe jmp ffffffff814e7ed4
> <tcp_fragment+0x24>
So skb->len = 0x1540 and len = 0x1708
I suspect we should push commit 2fceec13375e5d98 (tcp: len check is
unnecessarily devastating, change to WARN_ON) to stable if not already
done...
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=2fceec13375e5d98
David, is this commit in your stable queue ?
Thanks !
next prev parent reply other threads:[~2011-05-13 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 17:11 kernel BUG at net/ipv4/tcp_output.c:1006! TB
2011-05-13 17:20 ` Ben Greear
2011-05-13 17:27 ` Eric Dumazet
2011-05-13 19:30 ` TB
2011-05-13 19:47 ` Eric Dumazet [this message]
2011-05-13 20:01 ` David Miller
2011-05-19 17:08 ` TB
2011-05-19 17:11 ` Eric Dumazet
2011-05-24 16:09 ` TB
2011-05-24 16:20 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305316058.3120.6.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@techboom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox