From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: [RFC] ethernet: avoid pre-assigned OUI values in random_ether_addr
Date: Sun, 15 May 2011 13:20:50 -0700 [thread overview]
Message-ID: <1305490850.8178.57.camel@Joe-Laptop> (raw)
In-Reply-To: <1305488809.3120.162.camel@edumazet-laptop>
On Sun, 2011-05-15 at 21:46 +0200, Eric Dumazet wrote:
> Le vendredi 13 mai 2011 à 17:17 -0700, Stephen Hemminger a écrit :
> > There are some addresses in the assigned vendor block that don't obey
> > the locally assigned convention. These should be avoided by random_ether_addr
> > assignment.
> We call random_ether_addr() for some virtual devices, maybe we can add a
> __random_ether_addr() helper for them and not avoid these OUI ?
Unless it's speed critical, it's probably not worthwhile.
I think that using get_random_bytes, because it can drain
the entropy pool, may not be a great thing to do.
There's little value in crypto secure OUI's for random
ethernet addresses.
I think using get_random_int or random32 is probably good
enough.
next prev parent reply other threads:[~2011-05-15 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 0:17 [RFC] ethernet: avoid pre-assigned OUI values in random_ether_addr Stephen Hemminger
2011-05-14 0:28 ` Rick Jones
2011-05-14 0:32 ` Stephen Hemminger
2011-05-14 0:44 ` Rick Jones
2011-05-14 1:00 ` Rick Jones
2011-05-14 6:28 ` Bill Fink
2011-05-16 14:29 ` Rick Jones
2011-05-15 19:46 ` Eric Dumazet
2011-05-15 20:20 ` Joe Perches [this message]
2011-05-15 21:10 ` Eric Dumazet
2011-05-16 15:46 ` Stephen Hemminger
2011-05-20 19:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305490850.8178.57.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox