From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: Stefanos Harhalakis <v13@v13.gr>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] ipv4: more compliant RFC 3168 support
Date: Mon, 16 May 2011 23:38:38 +0200 [thread overview]
Message-ID: <1305581918.9466.10.camel@edumazet-laptop> (raw)
In-Reply-To: <20110516213336.GD3290@nuttenaction>
Le lundi 16 mai 2011 à 23:33 +0200, Hagen Paul Pfeifer a écrit :
> * Eric Dumazet | 2011-05-15 18:01:50 [+0200]:
>
> >Problem of this version is that common frames in the Internet (NOT_ECT
> >or ECT_X or ECT_X) will take the longest path to come to "return 0;"
> >
> >a switch() version is fast because gcc emits a table based jump
>
> Sure? Is the table access not an dCache miss? E.g.
>
> 4003dc: ff 24 fd 58 06 40 00 jmpq *0x400658(,%rdi,8)
>
> Not sure if jump table access is superior these days ...
>
Check v2 of patch, it is fine, small, fast ;)
By the way, you dont want to know how many cpu cycles we spend in IP
defrag functions... Really its insane.
next prev parent reply other threads:[~2011-05-16 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201105141938.28344.v13@v13.gr>
[not found] ` <1305393402.3120.67.camel@edumazet-laptop>
[not found] ` <1305393711.3120.69.camel@edumazet-laptop>
[not found] ` <201105151337.22831.v13@v13.gr>
[not found] ` <1305461344.3120.112.camel@edumazet-laptop>
[not found] ` <1305464176.3120.113.camel@edumazet-laptop>
2011-05-15 13:35 ` [PATCH net-next-2.6] ipv4: more compliant RFC 3168 support Eric Dumazet
2011-05-15 15:08 ` Stefanos Harhalakis
2011-05-15 16:01 ` Eric Dumazet
2011-05-16 17:16 ` Eric Dumazet
2011-05-16 18:37 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2011-05-16 18:49 ` David Miller
2011-05-16 19:17 ` Joe Perches
2011-05-16 21:33 ` [PATCH net-next-2.6] " Hagen Paul Pfeifer
2011-05-16 21:38 ` Eric Dumazet [this message]
2011-05-16 21:49 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305581918.9466.10.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=v13@v13.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox