From: Ben Hutchings <ben@decadent.org.uk>
To: hayeswang <hayeswang@realtek.com>
Cc: 'Francois Romieu' <romieu@fr.zoreil.com>,
'David Woodhouse' <dwmw2@infradead.org>,
netdev@vger.kernel.org
Subject: RE: [PATCH 1/2] linux-firmware: update firmware for RTL8111E
Date: Tue, 17 May 2011 03:39:47 +0100 [thread overview]
Message-ID: <1305599987.19966.99.camel@localhost> (raw)
In-Reply-To: <883AEB89D11D495A9666E2F73C2CD95F@realtek.com.tw>
[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]
On Tue, 2011-05-10 at 10:09 +0800, hayeswang wrote:
>
> Francois Romieu [mailto:romieu@fr.zoreil.com]
> > Sent: Tuesday, May 10, 2011 3:23 AM
> > To: David Woodhouse
> > Cc: Hayeswang; netdev@vger.kernel.org
> > Subject: Re: [PATCH 1/2] linux-firmware: update firmware for RTL8111E
> >
> > David Woodhouse <dwmw2@infradead.org> :
> > [...]
> > > I'd be a lot happier if the WHENCE file contained version numbers.
> > > Does the *driver* print a version string for the firmware
> > after loading it?
> >
> > No.
> >
> > Hayes, do we agree that the firmware needs to embed a version
> > identifier (and some checksum to identify the current
> > firmware that don't embed one).
> >
>
> I agree that. However, I have no idea about making it compatible with previous
> parser and firmware. Let me think if there is a good way to do this.
A PHY_DATA_AND at the beginning of a firmware blob instruction is a
no-op, so you could use that to add version information in a compatible
way. For RTL8168D, however, you are right that this would break
compatibility with the earlier driver versions that only handled
PHY_WRITE.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2011-05-17 2:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 8:02 [PATCH 1/2] linux-firmware: update firmware for RTL8111E Hayes Wang
2011-05-09 8:02 ` [PATCH 2/2] linux-firmware: add new firmware for RTL8168E-VL Hayes Wang
2011-05-09 8:23 ` [PATCH 1/2] linux-firmware: update firmware for RTL8111E David Woodhouse
2011-05-09 19:23 ` Francois Romieu
2011-05-10 2:09 ` hayeswang
2011-05-17 2:39 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305599987.19966.99.camel@localhost \
--to=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).