From: Rick Jones <rick.jones2@hp.com>
To: Tom Herbert <therbert@google.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: small RPS cache for fragments?
Date: Tue, 17 May 2011 13:17:14 -0700 [thread overview]
Message-ID: <1305663434.8149.936.camel@tardy> (raw)
In-Reply-To: <BANLkTikyH=q_6uOvFh3_Z_xwPST3zVijZw@mail.gmail.com>
On Tue, 2011-05-17 at 13:02 -0700, Tom Herbert wrote:
> I like it! And this sounds like the sort of algorithm that NICs might
> be able to implement to solve the UDP/RSS unpleasantness, so even
> better.
Do (m)any devices take "shortcuts" with UDP datagrams these days? By
that I mean that back in the day, the HP-PB and "Slider" FDDI
cards/drivers did checksum offload for fragmented UDP datagrams by
sending the first fragment, the one with the UDP header and thus
checksum, last. It did that to save space on the card and make use of
the checksum accumulator.
rick jones
>
> Tom
>
> On Tue, May 17, 2011 at 11:33 AM, David Miller <davem@davemloft.net> wrote:
> >
> > It seems to me that we can solve the UDP fragmentation problem for
> > flow steering very simply by creating a (saddr/daddr/IPID) entry in a
> > table that maps to the corresponding RPS flow entry.
> >
> > When we see the initial frag with the UDP header, we create the
> > saddr/daddr/IPID mapping, and we tear it down when we hit the
> > saddr/daddr/IPID mapping and the packet has the IP_MF bit clear.
> >
> > We only inspect the saddr/daddr/IPID cache when iph->frag_off is
> > non-zero.
> >
> > It's best effort and should work quite well.
> >
> > Even a one-behind cache, per-NAPI instance, would do a lot better than
> > what happens at the moment. Especially since the IP fragments mostly
> > arrive as one packet train.
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-17 20:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 18:33 small RPS cache for fragments? David Miller
2011-05-17 20:02 ` Tom Herbert
2011-05-17 20:17 ` Rick Jones [this message]
2011-05-17 20:41 ` Rick Jones
2011-05-17 20:49 ` David Miller
2011-05-17 21:00 ` Eric Dumazet
2011-05-17 21:10 ` David Miller
2011-05-17 21:13 ` Rick Jones
2011-05-17 21:13 ` Ben Hutchings
2011-05-17 21:26 ` David Miller
2011-05-17 21:40 ` Rick Jones
2011-05-17 21:27 ` Eric Dumazet
2011-05-17 21:11 ` Rick Jones
2011-05-17 21:11 ` Ben Hutchings
2011-05-17 21:27 ` Tom Herbert
2011-05-17 21:28 ` David Miller
2011-05-17 23:59 ` Changli Gao
2011-05-18 6:37 ` David Miller
2011-05-17 20:14 ` Eric Dumazet
2011-05-17 20:47 ` David Miller
2011-05-17 21:44 ` Andi Kleen
2011-05-17 21:52 ` Eric Dumazet
2011-05-17 22:03 ` Andi Kleen
2011-05-17 21:44 ` David Miller
2011-05-17 21:48 ` Andi Kleen
2011-05-17 21:50 ` David Miller
2011-05-17 22:06 ` Andi Kleen
2011-05-17 22:42 ` Rick Jones
2011-05-24 20:01 ` David Miller
2011-05-24 21:38 ` Rick Jones
2011-06-04 20:29 ` David Miller
2011-06-06 17:08 ` Rick Jones
2011-06-06 17:15 ` Eric Dumazet
2011-06-06 18:06 ` Rick Jones
2011-06-06 19:23 ` David Miller
2011-06-06 19:22 ` David Miller
2011-06-06 20:05 ` Rick Jones
2011-06-06 21:06 ` Jay Vosburgh
2011-06-06 21:40 ` David Miller
2011-06-06 22:49 ` Chris Friesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305663434.8149.936.camel@tardy \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).