Re: [PATCH net-next-2.6] sfc: Replace enum efx_fc_type with a 'bitwise' type

Jeff Garzik
2011-05-18T02:59:05Z

On 05/17/2011 10:23 PM, David Miller wrote:
> From: Jeff Garzik<jeff@garzik.org>
>
>> On 05/17/2011 05:14 PM, David Miller wrote:
>>> Accept that the compiler currently doesn't want to allow enums to be
>>> used as bit-masks, don't paper around it.
>>
>> This practice is all over the kernel.
>>
>> It's a bit silly to make such a big deal, because of that.
>
> "We do something stupid everywhere" is never a good
> argument for anything.

grepping across the kernel, it is clearly a useful shorthand technique
for defining typed, named constants, including bitmasks, used widely
across multiple subsystems, drivers and include/linux.

Given that this technique has passed review time and again, and that
kernel hackers -do- find it useful for valid reasons, I guess the only
remaining defense is to call something "stupid."

Jeff