From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] SCTP: fix race between sctp_bind_addr_free() and sctp_bind_addr_conflict() Date: Wed, 18 May 2011 13:41:42 +0200 Message-ID: <1305718902.2991.3.camel@edumazet-laptop> References: <1305704885.2983.4.camel@edumazet-laptop> <1305707358.2983.14.camel@edumazet-laptop> <4DD38B30.9090601@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Wei Yongjun , netdev@vger.kernel.org, Vlad Yasevich To: Jacek Luczak Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:58810 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932815Ab1ERLlp (ORCPT ); Wed, 18 May 2011 07:41:45 -0400 Received: by fxm17 with SMTP id 17so1118088fxm.19 for ; Wed, 18 May 2011 04:41:44 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Le mercredi 18 mai 2011 =C3=A0 13:01 +0200, Jacek Luczak a =C3=A9crit : > @Eric, if you will take a look into the code you might notice > that there are few places where list operations could be > optimised and the main question here is do we really care > to have the data ,,safe'' so that things like that won't popup. > The good example can be the set of _local_ functions. > Ahhh... and I'm aware of how tricky can be abuse of RCU. I took a quick look at existing rcu_read_lock() uses in sctp and did no= t find other problems [or optimizations if you prefer this point of view]= =2E Please elaborate.