From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yaniv Rosner" Subject: Re: [PATCH net-next 04/11] bnx2x: Add TX fault check for fiber PHYs Date: Mon, 23 May 2011 09:46:24 +0300 Message-ID: <1306133184.20872.100.camel@lb-tlvb-dmitry> References: <1306063927.20872.86.camel@lb-tlvb-dmitry> <1306128018.3456.35.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "Yaniv Rosner" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "Eilon Greenstein" To: "Ben Hutchings" Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:2900 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925Ab1EWGq1 (ORCPT ); Mon, 23 May 2011 02:46:27 -0400 In-Reply-To: <1306128018.3456.35.camel@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2011-05-22 at 22:20 -0700, Ben Hutchings wrote: > On Sun, 2011-05-22 at 14:32 +0300, Yaniv Rosner wrote: > > In case TX fault is detected on Fiber PHYs, declare the link as down > > until TX fault is gone. > [...] > > --- a/drivers/net/bnx2x/bnx2x_reg.h > > +++ b/drivers/net/bnx2x/bnx2x_reg.h > > @@ -6037,6 +6037,7 @@ Theotherbitsarereservedandshouldbezero*/ > > #define MDIO_PMA_REG_BCM_CTRL 0x0096 > > #define MDIO_PMA_REG_FEC_CTRL 0x00ab > > #define MDIO_PMA_REG_RX_ALARM_CTRL 0x9000 > > +#define MDIO_PMA_REG_TX_ALARM_CTRL 0x9001 > > #define MDIO_PMA_REG_LASI_CTRL 0x9002 > > #define MDIO_PMA_REG_RX_ALARM 0x9003 > > #define MDIO_PMA_REG_TX_ALARM 0x9004 > > By the way, the LASI registers are already named in : We will remove those private redundant definitions. > > #define MDIO_PMA_LASI_RXCTRL 0x9000 /* RX_ALARM control */ > #define MDIO_PMA_LASI_TXCTRL 0x9001 /* TX_ALARM control */ > #define MDIO_PMA_LASI_CTRL 0x9002 /* LASI control */ > #define MDIO_PMA_LASI_RXSTAT 0x9003 /* RX_ALARM status */ > #define MDIO_PMA_LASI_TXSTAT 0x9004 /* TX_ALARM status */ > #define MDIO_PMA_LASI_STAT 0x9005 /* LASI status */ > > Ben. > Thanks, Yaniv