From: Eric Dumazet <eric.dumazet@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>,
akpm@linux-foundation.org, netdev@vger.kernel.org,
drosenberg@vsecurity.com, a.p.zijlstra@chello.nl,
eparis@parisplace.org, eugeneteo@kernel.org, jmorris@namei.org,
kees.cook@canonical.com, tgraf@infradead.org
Subject: Re: [patch 1/1] net: convert %p usage to %pK
Date: Tue, 24 May 2011 09:45:01 +0200 [thread overview]
Message-ID: <1306223101.2638.43.camel@edumazet-laptop> (raw)
In-Reply-To: <1306222507.2298.23.camel@Joe-Laptop>
Le mardi 24 mai 2011 à 00:35 -0700, Joe Perches a écrit :
> I think it's be better without the casts
> using the standard kernel.h macros.
>
> void *ptr;
>
> ptr = maybe_hide_ptr(sk);
> r->id.idiag_cookie[0] = lower_32_bits(ptr);
> r->id.idiag_cookie[1] = upper_32_bits(ptr);
>
I am not sure I want to patch lower_32_bits() and upper_32_bits() for
this.
They dont work on pointers, but on "numbers", according to kerneldoc
Andrew wrote years ago. gcc agrees :
net/ipv4/inet_diag.c: In function ‘inet_csk_diag_fill’:
net/ipv4/inet_diag.c:119: warning: cast from pointer to integer of different size
net/ipv4/inet_diag.c:120: error: invalid operands to binary >>
make[1]: *** [net/ipv4/inet_diag.o] Error 1
next prev parent reply other threads:[~2011-05-24 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 22:17 [patch 1/1] net: convert %p usage to %pK akpm
2011-05-24 5:13 ` David Miller
2011-05-24 6:17 ` Eric Dumazet
2011-05-24 6:33 ` Joe Perches
2011-05-24 6:57 ` Ingo Molnar
2011-05-24 7:04 ` Eric Dumazet
2011-05-24 7:35 ` Joe Perches
2011-05-24 7:45 ` Eric Dumazet [this message]
2011-05-24 7:58 ` David Miller
2011-05-24 14:43 ` Stephen Hemminger
2011-05-24 17:18 ` David Miller
2011-05-25 23:29 ` Kees Cook
2011-05-26 1:50 ` David Miller
2011-05-27 0:14 ` Kees Cook
2011-05-27 2:44 ` David Miller
2011-05-27 3:10 ` Eric Dumazet
2011-05-27 6:37 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306223101.2638.43.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=eparis@parisplace.org \
--cc=eugeneteo@kernel.org \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kees.cook@canonical.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox