netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
	davem@davemloft.net, bhutchings@solarflare.com
Subject: [PATCH 2/2] net: make dev_disable_lro use physical device if passed a vlan dev (v2)
Date: Tue, 24 May 2011 14:31:09 -0400	[thread overview]
Message-ID: <1306261869-7276-3-git-send-email-nhorman@tuxdriver.com> (raw)
In-Reply-To: <1306261869-7276-1-git-send-email-nhorman@tuxdriver.com>

If the device passed into dev_disable_lro is a vlan, then repoint the dev
poniter so that we actually modify the underlying physical device.

Signed-of-by: Neil Horman <nhorman@tuxdriver.com>
CC: davem@davemloft.net
CC: bhutchings@solarflare.com
---
 net/core/dev.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index d945379..da16c6a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1308,6 +1308,13 @@ void dev_disable_lro(struct net_device *dev)
 {
 	u32 flags;
 
+	/*
+ 	 * If we're trying to disable lro on a vlan device
+ 	 * use the underlying physical device instead
+ 	 */
+	if (is_vlan_dev(dev))
+		dev = vlan_dev_real_dev(dev);
+
 	if (dev->ethtool_ops && dev->ethtool_ops->get_flags)
 		flags = dev->ethtool_ops->get_flags(dev);
 	else
-- 
1.7.5.1


  parent reply	other threads:[~2011-05-24 18:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 17:15 net: enable dynamic lro disabling for vlans Neil Horman
2011-05-24 17:15 ` [PATCH 1/2] net: add dev_ethtool_set_flags helper Neil Horman
2011-05-24 17:15 ` [PATCH 2/2] net: add passthrough ethtool commands for get/set flags to vlan dev Neil Horman
2011-05-24 17:22 ` net: enable dynamic lro disabling for vlans Ben Hutchings
2011-05-24 17:54   ` Neil Horman
2011-05-24 18:31 ` net: enable dynamic lro disabling for vlans (v2) Neil Horman
2011-05-24 18:31   ` [PATCH 1/2] net: move is_vlan_dev into public header file (v2) Neil Horman
2011-05-24 18:36     ` Joe Perches
2011-05-24 19:03       ` Neil Horman
2011-05-25 21:56     ` David Miller
2011-05-24 18:31   ` Neil Horman [this message]
2011-05-25 21:56     ` [PATCH 2/2] net: make dev_disable_lro use physical device if passed a vlan dev (v2) David Miller
2011-05-28  3:11     ` Ben Hutchings
2011-05-31  0:06       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306261869-7276-3-git-send-email-nhorman@tuxdriver.com \
    --to=nhorman@tuxdriver.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).