* [PATCH] bonding:update xmit_hash_policy description
@ 2011-05-25 10:05 Weiping Pan
2011-05-25 14:40 ` Andy Gospodarek
0 siblings, 1 reply; 2+ messages in thread
From: Weiping Pan @ 2011-05-25 10:05 UTC (permalink / raw)
To: jpirko
Cc: Weiping Pan, Jay Vosburgh, Andy Gospodarek,
open list:BONDING DRIVER, open list
xmit_hash_policy supports layer2+3 now,
and both balance-xor and 802.3ad use xmit_hash_policy.
Signed-off-by: Weiping Pan <panweiping3@gmail.com>
---
drivers/net/bonding/bond_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 088fd84..d1f5606 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -147,8 +147,7 @@ MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner "
module_param(ad_select, charp, 0);
MODULE_PARM_DESC(ad_select, "803.ad aggregation selection logic: stable (0, default), bandwidth (1), count (2)");
module_param(xmit_hash_policy, charp, 0);
-MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method: 0 for layer 2 (default)"
- ", 1 for layer 3+4");
+MODULE_PARM_DESC(xmit_hash_policy, "balance-xor and 802.3ad hashing method: 0 for layer 2 (default), 1 for layer 3+4, 2 for layer 2+3");
module_param(arp_interval, int, 0);
MODULE_PARM_DESC(arp_interval, "arp interval in milliseconds");
module_param_array(arp_ip_target, charp, NULL, 0);
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bonding:update xmit_hash_policy description
2011-05-25 10:05 [PATCH] bonding:update xmit_hash_policy description Weiping Pan
@ 2011-05-25 14:40 ` Andy Gospodarek
0 siblings, 0 replies; 2+ messages in thread
From: Andy Gospodarek @ 2011-05-25 14:40 UTC (permalink / raw)
To: Weiping Pan
Cc: jpirko, Jay Vosburgh, Andy Gospodarek, open list:BONDING DRIVER,
open list
On Wed, May 25, 2011 at 06:05:04PM +0800, Weiping Pan wrote:
> xmit_hash_policy supports layer2+3 now,
> and both balance-xor and 802.3ad use xmit_hash_policy.
>
> Signed-off-by: Weiping Pan <panweiping3@gmail.com>
> ---
> drivers/net/bonding/bond_main.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 088fd84..d1f5606 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -147,8 +147,7 @@ MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner "
> module_param(ad_select, charp, 0);
> MODULE_PARM_DESC(ad_select, "803.ad aggregation selection logic: stable (0, default), bandwidth (1), count (2)");
> module_param(xmit_hash_policy, charp, 0);
> -MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method: 0 for layer 2 (default)"
> - ", 1 for layer 3+4");
> +MODULE_PARM_DESC(xmit_hash_policy, "balance-xor and 802.3ad hashing method: 0 for layer 2 (default), 1 for layer 3+4, 2 for layer 2+3");
This is a good idea and a definite bug-fix. Thanks for posting it.
I do not want to create a description that is longer than 80 characters
in the source if I can help it. I went ahead and cleaned up all the
descriptions and have posted a followup patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-25 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-25 10:05 [PATCH] bonding:update xmit_hash_policy description Weiping Pan
2011-05-25 14:40 ` Andy Gospodarek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).