* [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
@ 2011-05-26 16:28 Dmitry Kravkov
2011-05-26 16:41 ` Dmitry Kravkov
2011-05-26 17:39 ` David Miller
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Kravkov @ 2011-05-26 16:28 UTC (permalink / raw)
To: david Miller, netdev@vger.kernel.org; +Cc: Jacek Luczak
---
net/sctp/bind_addr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c
index 6338413..83e3011 100644
--- a/net/sctp/bind_addr.c
+++ b/net/sctp/bind_addr.c
@@ -145,7 +145,7 @@ static void sctp_bind_addr_clean(struct sctp_bind_addr *bp)
/* Empty the bind address list. */
list_for_each_entry_safe(addr, temp, &bp->address_list, list) {
list_del_rcu(&addr->list);
- call_rcu(&addr->rcu, sctp_local_addr_free);
+ kfree_rcu(addr, rcu);
SCTP_DBG_OBJCNT_DEC(addr);
}
}
--
1.7.2.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
2011-05-26 16:28 [PATCH] sctp compilation failed due to lack of sctp_local_addr_free Dmitry Kravkov
@ 2011-05-26 16:41 ` Dmitry Kravkov
2011-05-26 17:39 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: Dmitry Kravkov @ 2011-05-26 16:41 UTC (permalink / raw)
To: david Miller, Jacek Luczak; +Cc: netdev@vger.kernel.org
On Thu, 2011-05-26 at 09:28 -0700, Dmitry Kravkov wrote:
> ---
> net/sctp/bind_addr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
It was easier to fix it like commit
1231f0baa547a541a7481119323b7f964dda4788 does, than to disable it in
kernel config :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
2011-05-26 16:28 [PATCH] sctp compilation failed due to lack of sctp_local_addr_free Dmitry Kravkov
2011-05-26 16:41 ` Dmitry Kravkov
@ 2011-05-26 17:39 ` David Miller
2011-05-26 18:40 ` Allan, Bruce W
1 sibling, 1 reply; 7+ messages in thread
From: David Miller @ 2011-05-26 17:39 UTC (permalink / raw)
To: dmitry; +Cc: netdev, difrost.kernel
This has been fixed for days.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
2011-05-26 17:39 ` David Miller
@ 2011-05-26 18:40 ` Allan, Bruce W
2011-05-26 18:44 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Allan, Bruce W @ 2011-05-26 18:40 UTC (permalink / raw)
To: David Miller, dmitry@broadcom.com
Cc: netdev@vger.kernel.org, difrost.kernel@gmail.com
>-----Original Message-----
>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>Behalf Of David Miller
>Sent: Thursday, May 26, 2011 10:39 AM
>To: dmitry@broadcom.com
>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com
>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
>
>
>This has been fixed for days.
Fixed in net-2.6, yes, but not yet in net-next-2.6
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
2011-05-26 18:40 ` Allan, Bruce W
@ 2011-05-26 18:44 ` David Miller
2011-05-26 19:07 ` Dmitry Kravkov
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2011-05-26 18:44 UTC (permalink / raw)
To: bruce.w.allan; +Cc: dmitry, netdev, difrost.kernel
From: "Allan, Bruce W" <bruce.w.allan@intel.com>
Date: Thu, 26 May 2011 11:40:34 -0700
>>-----Original Message-----
>>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>>Behalf Of David Miller
>>Sent: Thursday, May 26, 2011 10:39 AM
>>To: dmitry@broadcom.com
>>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com
>>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
>>
>>
>>This has been fixed for days.
>
> Fixed in net-2.6, yes, but not yet in net-next-2.6
net-next-2.6 is not active and is just a dummy tree for Stephen
Rothwell to pull into -next
You should never be referencing or using net-next-2.6 during the
merge window when new features changes are not being accepted.
Only net-2.6 is active during this time.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
2011-05-26 18:44 ` David Miller
@ 2011-05-26 19:07 ` Dmitry Kravkov
2011-05-26 19:58 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Kravkov @ 2011-05-26 19:07 UTC (permalink / raw)
To: David Miller
Cc: bruce.w.allan@intel.com, netdev@vger.kernel.org,
difrost.kernel@gmail.com
On Thu, 2011-05-26 at 11:44 -0700, David Miller wrote:
> From: "Allan, Bruce W" <bruce.w.allan@intel.com>
> Date: Thu, 26 May 2011 11:40:34 -0700
>
> >>-----Original Message-----
> >>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
> >>Behalf Of David Miller
> >>Sent: Thursday, May 26, 2011 10:39 AM
> >>To: dmitry@broadcom.com
> >>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com
> >>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
> >>
> >>
> >>This has been fixed for days.
> >
> > Fixed in net-2.6, yes, but not yet in net-next-2.6
>
> net-next-2.6 is not active and is just a dummy tree for Stephen
> Rothwell to pull into -next
>
> You should never be referencing or using net-next-2.6 during the
> merge window when new features changes are not being accepted.
> Only net-2.6 is active during this time.
>
Hmm, so how similar will be net-2.6 and net-next-2.6 when re-opened?
You apply a lot of fixes during this time...
And yes, i've hit the compilation error in net-next since i'm using it
as basis for future features submit
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
2011-05-26 19:07 ` Dmitry Kravkov
@ 2011-05-26 19:58 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2011-05-26 19:58 UTC (permalink / raw)
To: dmitry; +Cc: bruce.w.allan, netdev, difrost.kernel
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Thu, 26 May 2011 22:07:01 +0300
> On Thu, 2011-05-26 at 11:44 -0700, David Miller wrote:
>> From: "Allan, Bruce W" <bruce.w.allan@intel.com>
>> Date: Thu, 26 May 2011 11:40:34 -0700
>>
>> >>-----Original Message-----
>> >>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>> >>Behalf Of David Miller
>> >>Sent: Thursday, May 26, 2011 10:39 AM
>> >>To: dmitry@broadcom.com
>> >>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com
>> >>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free
>> >>
>> >>
>> >>This has been fixed for days.
>> >
>> > Fixed in net-2.6, yes, but not yet in net-next-2.6
>>
>> net-next-2.6 is not active and is just a dummy tree for Stephen
>> Rothwell to pull into -next
>>
>> You should never be referencing or using net-next-2.6 during the
>> merge window when new features changes are not being accepted.
>> Only net-2.6 is active during this time.
>>
> Hmm, so how similar will be net-2.6 and net-next-2.6 when re-opened?
> You apply a lot of fixes during this time...
When it opens up I just update net-next-2.6 to whatever is in net-2.6
at the time.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-05-26 19:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 16:28 [PATCH] sctp compilation failed due to lack of sctp_local_addr_free Dmitry Kravkov
2011-05-26 16:41 ` Dmitry Kravkov
2011-05-26 17:39 ` David Miller
2011-05-26 18:40 ` Allan, Bruce W
2011-05-26 18:44 ` David Miller
2011-05-26 19:07 ` Dmitry Kravkov
2011-05-26 19:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).