netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Oliver Neukum <oliver@neukum.name>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Stefan Metzmacher <metze@samba.org>
Subject: [PATCH] usbnet/cdc_ncm: add missing .reset_resume hook
Date: Wed,  1 Jun 2011 11:13:50 +0200	[thread overview]
Message-ID: <1306919630-13426-2-git-send-email-metze@samba.org> (raw)
In-Reply-To: <1306919630-13426-1-git-send-email-metze@samba.org>

This avoids messages like this after suspend:

   cdc_ncm 2-1.4:1.6: no reset_resume for driver cdc_ncm?
   cdc_ncm 2-1.4:1.7: no reset_resume for driver cdc_ncm?
   cdc_ncm 2-1.4:1.6: usb0: unregister 'cdc_ncm' usb-0000:00:1d.0-1.4, CDC NCM

This is important for the Ericsson F5521gw GSM/UMTS modem.
Otherwise modemmanager looses the fact that the cdc_ncm and cdc_acm devices
belong together.

The cdc_ether module does the same.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
---
 drivers/net/usb/cdc_ncm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index cdd3ae4..3257aaa 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1234,6 +1234,7 @@ static struct usb_driver cdc_ncm_driver = {
 	.disconnect = cdc_ncm_disconnect,
 	.suspend = usbnet_suspend,
 	.resume = usbnet_resume,
+	.reset_resume =	usbnet_resume,
 	.supports_autosuspend = 1,
 };
 
-- 
1.7.4.1

  reply	other threads:[~2011-06-01  9:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01  9:13 cdc_ncm: device gets unregistered on resume Stefan Metzmacher
2011-06-01  9:13 ` Stefan Metzmacher [this message]
2011-06-01  9:43   ` [PATCH] usbnet/cdc_ncm: add missing .reset_resume hook Oliver Neukum
     [not found]     ` <201106011143.46667.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-06-01 10:03       ` Stefan (metze) Metzmacher
2011-06-01 10:08         ` Alexey ORISHKO
2011-06-01 12:01           ` Stefan Metzmacher
2011-06-01 12:01             ` Stefan Metzmacher
2011-06-02  4:11               ` David Miller
2011-06-06 12:23                 ` Stefan (metze) Metzmacher
2011-06-06 15:06                   ` Greg KH
2011-06-07  7:38                     ` Stefan (metze) Metzmacher
2011-06-07 14:43                       ` Greg KH
2011-06-07 17:07                         ` Stefan (metze) Metzmacher
2011-06-07 17:35                           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306919630-13426-2-git-send-email-metze@samba.org \
    --to=metze@samba.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).