From: Ben Hutchings <bhutchings@solarflare.com>
To: s.poehn@stud.hs-esslingen.de
Cc: netdev@vger.kernel.org, sebastian.poehn@belden.com,
Alexander Duyck <alexander.h.duyck@intel.com>,
Santwona Behera <santwona.behera@sun.com>
Subject: Re: [PATCH] ethtool: change spi param on ip4 to l4data
Date: Wed, 01 Jun 2011 22:59:42 +0100 [thread overview]
Message-ID: <1306965582.2758.42.camel@bwh-desktop> (raw)
In-Reply-To: <32899.80.254.147.148.1305618034.squirrel@webmail.hs-esslingen.de>
On Tue, 2011-05-17 at 09:40 +0200, Sebastian Pöhn wrote:
> It is confusing for users if ip4 has a spi field, which results in
> l4_4_bytes filtering. Add a new option and remove spi from ip4.
[...]
There are supposed to have multiple aliases for setting the l4_4_bytes
field, depending on the layer-4 protocol: 'spi', 'src-port', 'dst-port',
and potentially others. These could be used when the hardware doesn't
have specific support for the L4 protocol but can filter on the first 4
bytes of its header.
You could change the manual page to explain the assumptions behind these
options. You could also add this generic option (l4data, or possibly
options for each of the 4 bytes). But don't remove the existing ones.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-06-01 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 7:40 [PATCH] ethtool: change spi param on ip4 to l4data Sebastian Pöhn
2011-06-01 21:59 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306965582.2758.42.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=netdev@vger.kernel.org \
--cc=s.poehn@stud.hs-esslingen.de \
--cc=santwona.behera@sun.com \
--cc=sebastian.poehn@belden.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).