From: Neil Horman <nhorman@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH] bonding: reset queue mapping prior to transmission to physical device (v3)
Date: Fri, 3 Jun 2011 13:32:33 -0400 [thread overview]
Message-ID: <1307122353-3414-1-git-send-email-nhorman@tuxdriver.com> (raw)
In-Reply-To: <1307112216.2789.16.camel@bwh-desktop>
The bonding driver is multiqueue enabled, in which each queue represents a slave
to enable optional steering of output frames to given slaves against the default
output policy. However, it needs to reset the skb->queue_mapping prior to
queuing to the physical device or the physical slave (if it is multiqueue) could
wind up transmitting on an unintended tx queue
Change Notes:
v2) Based on first pass review, updated the patch to restore the origional queue
mapping that was found in bond_select_queue, rather than simply resetting to
zero. This preserves the value of queue_mapping when it was set on receive in
the forwarding case which is desireable.
v3) Fixed spelling an casting error in skb->cb
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Jay Vosburgh <fubar@us.ibm.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: "David S. Miller" <davem@davemloft.net>
---
drivers/net/bonding/bond_main.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 17b4dd9..dbb1048 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -400,6 +400,11 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb,
{
skb->dev = slave_dev;
skb->priority = 1;
+ /*
+ *restore the origional mapping
+ */
+ skb_set_queue_mapping(skb, ((u16 *)skb->cb)[0]);
+
if (unlikely(netpoll_tx_running(slave_dev)))
bond_netpoll_send_skb(bond_get_slave_by_dev(bond, slave_dev), skb);
else
@@ -4216,6 +4221,11 @@ static u16 bond_select_queue(struct net_device *dev, struct sk_buff *skb)
*/
u16 txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : 0;
+ /*
+ * Save the original txq to restore before passing to the driver
+ */
+ ((u16 *)skb->cb)[0] = txq;
+
if (unlikely(txq >= dev->real_num_tx_queues)) {
do {
txq -= dev->real_num_tx_queues;
--
1.7.3.4
next prev parent reply other threads:[~2011-06-03 17:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 18:03 [PATCH] bonding: reset queue mapping prior to transmission to physical device Neil Horman
2011-06-02 18:35 ` Ben Hutchings
2011-06-02 18:56 ` Neil Horman
2011-06-02 19:09 ` Ben Hutchings
2011-06-02 19:46 ` Neil Horman
2011-06-02 19:52 ` Nicolas de Pesloüan
2011-06-02 20:04 ` David Miller
2011-06-02 20:13 ` Nicolas de Pesloüan
2011-06-02 20:46 ` David Miller
2011-06-02 20:51 ` Ben Hutchings
2011-06-02 21:10 ` David Miller
2011-06-02 20:13 ` Ben Hutchings
2011-06-03 1:16 ` Neil Horman
2011-06-02 19:59 ` David Miller
2011-06-02 20:07 ` David Miller
2011-06-02 20:22 ` Nicolas de Pesloüan
2011-06-03 1:04 ` Neil Horman
2011-06-03 13:26 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v2) Neil Horman
2011-06-03 14:43 ` Ben Hutchings
2011-06-03 17:32 ` Neil Horman [this message]
2011-06-03 17:59 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v3) Ben Hutchings
2011-06-03 18:36 ` Neil Horman
2011-06-03 19:12 ` Ben Hutchings
2011-06-03 19:23 ` Neil Horman
2011-06-03 19:24 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v4) Neil Horman
2011-06-03 19:48 ` Eric Dumazet
2011-06-03 19:57 ` Neil Horman
2011-06-03 20:05 ` Eric Dumazet
2011-06-03 20:35 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v5) Neil Horman
2011-06-03 23:31 ` Jay Vosburgh
2011-06-05 21:32 ` David Miller
2011-06-03 18:06 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v3) Jay Vosburgh
2011-06-03 14:59 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v2) Vitalii Demianets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307122353-3414-1-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).