From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: bridge/netfilter: regression in 2.6.39.1
Date: Mon, 06 Jun 2011 15:18:12 +0200 [thread overview]
Message-ID: <1307366292.3098.17.camel@edumazet-laptop> (raw)
In-Reply-To: <20110606131309.GB1000@hmsreliant.think-freely.org>
Le lundi 06 juin 2011 à 09:13 -0400, Neil Horman a écrit :
> Ok, this makes sense to me now, thanks. The change to the dst initalization to
> mark our fake routing table as read only means we need a cow_metrics method to
> copy the metrics before we we can compete the dst_metric_set in br_change_mtu.
> Thats fine, but given that its really a fake routing table with only one dst
> entry which (I think) is only written under the rtnl lock, why not just modify
> the dst_init_metrics call so that its not marked as read-only?
It _is_ read-only, its even a "const", so if you do that you'll trap if
kernel const pages are RO
Please check commit 0972ddb237 for a proper way to deal with this.
next prev parent reply other threads:[~2011-06-06 13:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 19:21 bridge/netfilter: regression in 2.6.39.1 Alexander Holler
2011-06-03 19:34 ` Eric Dumazet
2011-06-03 19:42 ` Alexander Holler
2011-06-03 19:51 ` Alexander Holler
2011-06-03 19:55 ` Eric Dumazet
2011-06-04 12:04 ` Alexander Holler
2011-06-06 6:57 ` Alexander Holler
2011-06-03 22:31 ` Ben Hutchings
2011-06-06 11:15 ` Neil Horman
2011-06-06 11:48 ` Alexander Holler
2011-06-06 12:12 ` Eric Dumazet
2011-06-06 12:49 ` Alexander Holler
2011-06-06 13:13 ` Neil Horman
2011-06-06 13:18 ` Eric Dumazet [this message]
2011-06-06 13:16 ` Eric Dumazet
2011-06-06 13:29 ` Alexander Holler
2011-06-06 14:26 ` Eric Dumazet
2011-06-06 15:32 ` Neil Horman
2011-06-06 16:11 ` Eric Dumazet
2011-06-06 17:07 ` Neil Horman
2011-06-07 7:52 ` David Miller
2011-06-06 13:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307366292.3098.17.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=holler@ahsoftware.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox