From: Marc Kleine-Budde <mkl@pengutronix.de>
To: davem@davemloft.net
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 05/11] can: at91_can: directly define AT91_MB_RX_LAST
Date: Mon, 6 Jun 2011 15:42:54 +0200 [thread overview]
Message-ID: <1307367780-30715-6-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1307367780-30715-1-git-send-email-mkl@pengutronix.de>
...instead of deriving it from AT91_MB_RX_FIRST and AT91_MB_RX_NUM.
This removes a level of computation, when switching the driver from
compile time constants to runtime values.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/at91_can.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index 716f22b..9ce00fa 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -47,11 +47,10 @@
* RX/TX Mailbox split
* don't dare to touch
*/
-#define AT91_MB_RX_NUM 11
#define AT91_MB_TX_SHIFT 2
#define AT91_MB_RX_FIRST 1
-#define AT91_MB_RX_LAST (AT91_MB_RX_FIRST + AT91_MB_RX_NUM - 1)
+#define AT91_MB_RX_LAST 11
#define AT91_MB_RX_MASK(i) ((1 << (i)) - 1)
#define AT91_MB_RX_SPLIT 8
--
1.7.4.1
next prev parent reply other threads:[~2011-06-06 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 13:42 [PATCH 00/11] can: at91_can: add support for AT91SAM9X5 series Marc Kleine-Budde
2011-06-06 13:42 ` Marc Kleine-Budde [this message]
2011-06-06 13:42 ` [PATCH 06/11] can: at91_can: rename AT91_MB_RX_MASK to AT91_IRQ_MB_RX Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 09/11] can: at91_can: register mb0 sysfs entry only on at91sam9263 Marc Kleine-Budde
2011-06-06 13:43 ` [PATCH 11/11] net/can: allow CAN_AT91 on AT91SAM9X5 Marc Kleine-Budde
[not found] ` <1307367780-30715-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-06 13:42 ` [PATCH 01/11] can: at91_can: don't align struct definitions Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 02/11] can: at91_can: fix comment about priv->tx_next Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 03/11] can: at91_can: don't copy data to rx'ed RTR frames Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 04/11] can: at91_can: let get_tx_* functions return unsigned int Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 07/11] can: at91_can: convert derived mailbox constants into functions Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 08/11] can: at91_can: add id_table and convert prime mailbox constats to functions Marc Kleine-Budde
2011-06-06 13:42 ` [PATCH 10/11] can: at91_can: add support for the AT91SAM9X5 SOCs Marc Kleine-Budde
2011-06-07 8:05 ` [PATCH 00/11] can: at91_can: add support for AT91SAM9X5 series David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307367780-30715-6-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).