From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] v2 ethtool: remove support for ETHTOOL_GRXNTUPLE Date: Thu, 09 Jun 2011 00:03:47 +0100 Message-ID: <1307574227.22348.501.camel@localhost> References: <20110608223508.20551.45558.stgit@gitlad.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org To: Alexander Duyck Return-path: Received: from mail.solarflare.com ([216.237.3.220]:21054 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753678Ab1FHXDv (ORCPT ); Wed, 8 Jun 2011 19:03:51 -0400 In-Reply-To: <20110608223508.20551.45558.stgit@gitlad.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2011-06-08 at 15:35 -0700, Alexander Duyck wrote: > This change is meant to remove all support for displaying an ntuple as > strings via ETHTOOL_GRXNTUPLE. The reason for this change is due to the > fact that multiple issues have been found including: > - Multiple buffer overruns for strings being displayed. > - Incorrect filters displayed, cleared filters with ring of -2 are displayed > - Setting get_rx_ntuple displays no rules if defined. > - Endianess wrong on displayed values. > - Hard limit of 1024 filters makes display functionality extremely limited > > The only driver that had supported this interface was ixgbe. Since it no > longer uses the interface and due to the issues mentioned above I am > submitting this patch to remove it. > > v2: > Updated based on comments from Ben Hutchings > - Left ETH_SS_NTUPLE_FILTERS in code but commented on it being deprecated > - Removed ethtool_rx_ntuple_list and ethtool_rx_ntuple_flow_spec_container > - Left ETHTOOL_GRXNTUPLE but commented it as deprecated > > Also cleaned up set_rx_ntuple since there is no flow spec container to > maintain we can drop all the code for the alloc and free of it and just > return ops->set_rx_ntuple(). > Signed-off-by: Alexander Duyck Acked-by: Ben Hutchings Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.