From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [net-next 00/12][pull request] Intel Wired LAN Driver Update
Date: Thu, 09 Jun 2011 00:53:14 -0700 [thread overview]
Message-ID: <1307605995.32044.18.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20110609.005051.1530473933808285841.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
On Thu, 2011-06-09 at 00:50 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Thu, 09 Jun 2011 00:46:50 -0700
>
> >> Actually, I have to un-pull. Please build test your changes:
> >>
> >> drivers/infiniband/core/netlink.c: In function ‘ibnl_rcv_msg’:
> >> drivers/infiniband/core/netlink.c:151:9: error: too few arguments to function ‘netlink_dump_start’
> >> include/linux/netlink.h:260:12: note: declared here
> >> make[3]: *** [drivers/infiniband/core/netlink.o] Error 1
> >> make[2]: *** [drivers/infiniband/core] Error 2
> >> make[1]: *** [drivers/infiniband] Error 2
> >> make[1]: *** Waiting for unfinished jobs....
> >
> > I built tested after every patch and did not have any issues. I see
> > Greg made some changes to include/linux/netlink.h which may be the
> > result of this error.
>
> Well of course, the arguments to netlink_dump_start() changed and therefore
> every call site needs to be updated.
>
> Unless you don't have infiniband enabled in your builds, you should be
> hitting this build failure too.
Just did, I saw that I did not have enabled and I got the same issue. I
am looking into now, and will check to make sure there were no other
netlink_dump_start() references missed as well.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-06-09 7:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 22:56 [net-next 00/12][pull request] Intel Wired LAN Driver Update Jeff Kirsher
2011-06-08 22:56 ` [net-next 01/12] e1000e: disable far-end loopback mode on ESB2 Jeff Kirsher
2011-06-08 22:56 ` [net-next 02/12] e1000e: 82579 intermittently disabled during S0->Sx Jeff Kirsher
2011-06-08 22:56 ` [net-next 03/12] e1000e: log when swflag is cleared unexpectedly on ICH/PCH devices Jeff Kirsher
2011-06-08 22:56 ` [net-next 04/12] e1000e: do not schedule the Tx queue until ready Jeff Kirsher
2011-06-08 22:56 ` [net-next 05/12] e1000e: access multiple PHY registers on same page at the same time Jeff Kirsher
2011-06-08 22:56 ` [net-next 06/12] e1000e: Clear host wakeup bit on 82577/8 without touching PHY page 800 Jeff Kirsher
2011-06-08 22:56 ` [net-next 07/12] e1000e: remove redundant reverse dependency on CRC32 Jeff Kirsher
2011-06-08 22:56 ` [net-next 08/12] e1000e: update driver version Jeff Kirsher
2011-06-08 22:56 ` [net-next 09/12] igbvf: update version number Jeff Kirsher
2011-06-08 22:56 ` [net-next 10/12] igb: Change version to remove number after -k in kernel versions Jeff Kirsher
2011-06-08 22:56 ` [net-next 11/12] rtnetlink: Compute and store minimum ifinfo dump size Jeff Kirsher
2011-06-08 22:56 ` [net-next 12/12] ixgbevf: Update the driver string Jeff Kirsher
2011-06-09 7:05 ` [net-next 00/12][pull request] Intel Wired LAN Driver Update David Miller
2011-06-09 7:08 ` David Miller
2011-06-09 7:46 ` Jeff Kirsher
2011-06-09 7:50 ` David Miller
2011-06-09 7:53 ` Jeff Kirsher [this message]
2011-06-09 7:58 ` David Miller
2011-06-09 8:06 ` Jeff Kirsher
2011-06-09 8:14 ` Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2011-06-23 1:44 Jeff Kirsher
2011-10-12 3:38 Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307605995.32044.18.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).