From: Ben Hutchings <bhutchings@solarflare.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@suse.de>, Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"shemminger@vyatta.com" <shemminger@vyatta.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Request for review on Hyper-V virtual network driver
Date: Thu, 09 Jun 2011 23:49:08 +0100 [thread overview]
Message-ID: <1307659748.3127.42.camel@bwh-desktop> (raw)
In-Reply-To: <1307658497.18357.6.camel@Joe-Laptop>
On Thu, 2011-06-09 at 15:28 -0700, Joe Perches wrote:
[...]
> It's odd and a bit ugly to use #include "../../staging/hyperv.h"
>
> Maybe add another include path to the Makefile and just use
> #include "hyperv.h"
> until all of the hyperv files are moved out of staging?
It seems strange for files outside staging to have dependencies inside
staging. I think that header file should be moved out first (or at the
same time).
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-09 22:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 21:27 Request for review on Hyper-V virtual network driver Haiyang Zhang
2011-06-09 21:38 ` Joe Perches
2011-06-09 21:59 ` Haiyang Zhang
2011-06-09 22:07 ` Greg KH
2011-06-09 22:16 ` Haiyang Zhang
2011-06-09 22:28 ` Joe Perches
2011-06-09 22:36 ` Haiyang Zhang
2011-06-09 22:49 ` Ben Hutchings [this message]
2011-06-09 22:56 ` Haiyang Zhang
2011-06-09 23:00 ` Greg KH
2011-06-09 21:56 ` Randy Dunlap
2011-06-09 22:00 ` Haiyang Zhang
[not found] <A1F3067C9B68744AA19F6802BAB8FFDC09603BC2@TK5EX14MBXC227.redmond.corp.microsoft.com>
2011-06-09 19:28 ` Greg KH
2011-06-09 19:32 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307659748.3127.42.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=joe@perches.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).