From: "Michael Chan" <mchan@broadcom.com>
To: "Neil Horman" <nhorman@tuxdriver.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 5/5 net-next] cnic, bnx2: Check iSCSI support early in bnx2_init_one()
Date: Thu, 9 Jun 2011 17:37:11 -0700 [thread overview]
Message-ID: <1307666231.14980.4.camel@HP1> (raw)
In-Reply-To: <20110609104228.GA24178@hmsreliant.think-freely.org>
On Thu, 2011-06-09 at 03:42 -0700, Neil Horman wrote:
> On Wed, Jun 08, 2011 at 10:29:36PM -0700, Michael Chan wrote:
> > Based on earlier patch from Neil Horman <nhorman@tuxdriver.com>
> >
> > If iSCSI is not supported on a bnx2 device, bnx2_cnic_probe() will
> > return NULL and the cnic device will not be visible to bnx2i. This
> > will prevent bnx2i from registering and then unregistering during
> > cnic_start() and cause the warning message:
> >
> > bnx2 0003:01:00.1: eth1: Failed waiting for ULP up call to complete
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
> > Cc: Neil Horman <nhorman@tuxdriver.com>
> Thank you Michael. This also lets you eliminate some dead code in bnx2i_start
> now, since cdev->max_iscsi_conn will never be zero.
>
This is true for bnx2. For bnx2x, some devices may support FCoE only
and not iSCSI, so we still need code similar to what you proposed
yesterday. We'll add that through the scsi tree.
Thanks.
next prev parent reply other threads:[~2011-06-10 0:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 5:29 [PATCH 1/5 net-next] cnic: Fix interrupt logic Michael Chan
2011-06-09 5:29 ` [PATCH 2/5 net-next] cnic: Fix race conditions with firmware Michael Chan
2011-06-09 5:29 ` [PATCH 3/5 net-next] cnic: Randomize initial TCP port for iSCSI connections Michael Chan
2011-06-09 5:29 ` [PATCH 4/5 net-next] cnic: Improve NETDEV_UP event handling Michael Chan
2011-06-09 5:29 ` [PATCH 5/5 net-next] cnic, bnx2: Check iSCSI support early in bnx2_init_one() Michael Chan
2011-06-09 6:53 ` David Miller
2011-06-09 10:42 ` Neil Horman
2011-06-10 0:37 ` Michael Chan [this message]
2011-06-09 6:53 ` [PATCH 4/5 net-next] cnic: Improve NETDEV_UP event handling David Miller
2011-06-09 6:53 ` [PATCH 3/5 net-next] cnic: Randomize initial TCP port for iSCSI connections David Miller
2011-06-09 15:27 ` Stephen Hemminger
2011-06-10 1:08 ` Michael Chan
2011-06-10 4:01 ` Stephen Hemminger
2011-06-10 4:39 ` Eric Dumazet
2011-06-10 6:25 ` Michael Chan
2011-06-09 6:53 ` [PATCH 2/5 net-next] cnic: Fix race conditions with firmware David Miller
2011-06-09 6:52 ` [PATCH 1/5 net-next] cnic: Fix interrupt logic David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307666231.14980.4.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).