From: Ben Hutchings <bhutchings@solarflare.com>
To: Daniel Hellstrom <daniel@gaisler.com>
Cc: netdev@vger.kernel.org
Subject: Re: CRC endianess problem on DGE-510T
Date: Fri, 10 Jun 2011 13:35:01 +0100 [thread overview]
Message-ID: <1307709301.22348.594.camel@localhost> (raw)
In-Reply-To: <4DF1CFC2.5080101@gaisler.com>
On Fri, 2011-06-10 at 10:03 +0200, Daniel Hellstrom wrote:
> Hello,
>
> I'm having problems with the PCI network board D-LINK DGE-510T on
> SPARC32/LEON. The CRC calculated by ether_crc_le() does not match the
> CRC, however after swapping the result it matches. This is the same
> behaviour with the 3 boards I have. After applying the patch below
> everything works.
>
> Does anyone know if this is a correct patch or has had similar problems
> on big endian machines?
No idea about this hardware, but it looks reasonable - the contents of
the EEPROM are treated as being in little-endian order, except when
reading the CRC for comparison.
> Daniel
>
>
>
>
> From: Daniel Hellstrom <daniel@gaisler.com>
> Date: Wed, 6 Apr 2011 15:01:44 +0200
> [PATCH] dl2k: EEPROM CRC calculation wrong endianess on bigendian machine
>
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> ---
> drivers/net/dl2k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c
> index c445457..4bbbd7b 100644
> --- a/drivers/net/dl2k.c
> +++ b/drivers/net/dl2k.c
> @@ -346,7 +346,7 @@ parse_eeprom (struct net_device *dev)
> if (np->pdev->vendor == PCI_VENDOR_ID_DLINK) { /* D-Link Only */
> /* Check CRC */
> crc = ~ether_crc_le (256 - 4, sromdata);
> - if (psrom->crc != crc) {
> + if (psrom->crc != cpu_to_le32(crc)) {q
q?
Ben.
> printk (KERN_ERR "%s: EEPROM data CRC error.\n",
> dev->name);
> return -1;
> --
> 1.5.4
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-10 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 8:03 CRC endianess problem on DGE-510T Daniel Hellstrom
2011-06-10 12:35 ` Ben Hutchings [this message]
2011-06-10 13:12 ` Daniel Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307709301.22348.594.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=daniel@gaisler.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).