From: Elof Vrigborn <elof.vrigborn@ericsson.com>
To: Oliver Neukum <oliver@neukum.name>
Cc: <netdev@vger.kernel.org>, Elof Vrigborn <elof.vrigborn@ericsson.com>
Subject: [PATCH 1/1] cdc_ncm: Fix TCP Window Size issue by CDC NCM driver
Date: Fri, 10 Jun 2011 15:39:34 +0200 [thread overview]
Message-ID: <1307713174-533-1-git-send-email-elof.vrigborn@ericsson.com> (raw)
CDC NCM driver clones SKBs for received data and update SKB
members of the clones according to received frames.
If SKB clone len member is updated but truesize member is not, it
could cause check #2 of the tcp_grow_window function to increase
the TCP window by the __tcp_grow_window function instead of the
expected increment by 2*advmss. This could to a great extent
limit the rcv_ssthres and by that the advertised TCP Window Size,
and in the end the data rate of a TCP connection, as according to
the TCP Sliding Window concept.
With this patch the truesize member of the SKB clones is updated
in similarity to the len member and by this the expected incremental
of the advertised TCP Window Size is seen and the TCP connection
data rate will not be unnecessarily limited.
Signed-off-by: Elof Vrigborn <elof.vrigborn@ericsson.com>
---
drivers/net/usb/cdc_ncm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index f33ca6a..09923cd 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1083,6 +1083,7 @@ static int cdc_ncm_rx_fixup(struct usbnet *dev, struct sk_buff *skb_in)
if (!skb)
goto error;
skb->len = temp;
+ skb->truesize = temp + sizeof(struct sk_buff);
skb->data = ((u8 *)skb_in->data) + offset;
skb_set_tail_pointer(skb, temp);
usbnet_skb_return(dev, skb);
--
1.7.4.4
next reply other threads:[~2011-06-10 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 13:39 Elof Vrigborn [this message]
2011-06-10 14:10 ` [PATCH 1/1] cdc_ncm: Fix TCP Window Size issue by CDC NCM driver Eric Dumazet
2011-06-13 11:24 ` Elof Vrigborn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307713174-533-1-git-send-email-elof.vrigborn@ericsson.com \
--to=elof.vrigborn@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox