From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Andrea Merello <andrea.merello@gmail.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [E1000-devel] [PATCH] e100: Fix inconsistency in bad frames handling
Date: Tue, 14 Jun 2011 11:57:08 -0700 [thread overview]
Message-ID: <1308077828.4651.5.camel@jbrandeb-mobl2> (raw)
In-Reply-To: <4DF79AB1.2080109@candelatech.com>
On Tue, 2011-06-14 at 10:30 -0700, Ben Greear wrote:
> >> How would a received skb be flagged as having a CRC error?
> >>
> >
> > maybe some skb->pkt_type = PACKET_INVALID; or something...
>
> Jesse: If I can get the ethtool related patches accepted, would
> you accept patches to e100 (and other Intel drivers) for
> this feature?
seems like a reasonable thing, but, there is some risk that might
prevent us turning this on however, because we often like our hardware
to discard bad frames because (especially) long ones can use quite a few
buffers.
I still am generally uncomfortable with this idea. We've survived a
long time without it and it opens up the possibility of extra bugs (like
possible security issues, etc) with very little opportunity for
worthwhile gain.
Jesse
next prev parent reply other threads:[~2011-06-14 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTimpYniHhN6ccMXN7Lx3xDdK6sC+FQ@mail.gmail.com>
2011-06-06 17:49 ` [E1000-devel] [PATCH] e100: Fix inconsistency in bad frames handling Brandeburg, Jesse
2011-06-06 17:56 ` Ben Greear
2011-06-06 20:15 ` [E1000-devel] " Ben Hutchings
2011-06-06 20:20 ` Ben Greear
2011-06-06 20:29 ` Eric Dumazet
2011-06-06 22:45 ` Ben Greear
2011-06-14 17:30 ` Ben Greear
2011-06-14 18:57 ` Brandeburg, Jesse [this message]
2011-06-14 19:05 ` [E1000-devel] " Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308077828.4651.5.camel@jbrandeb-mobl2 \
--to=jesse.brandeburg@intel.com \
--cc=andrea.merello@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).