netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ppp: use PPP_TRANS instead of the magic number 0x20
@ 2011-06-15  7:58 Changli Gao
  2011-06-17  3:44 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Changli Gao @ 2011-06-15  7:58 UTC (permalink / raw)
  To: David S. Miller; +Cc: Paul Mackerras, linux-ppp, netdev, Changli Gao

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
 drivers/net/ppp_async.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c
index 6436ba9..c6ba643 100644
--- a/drivers/net/ppp_async.c
+++ b/drivers/net/ppp_async.c
@@ -524,7 +524,7 @@ static void ppp_async_process(unsigned long arg)
 #define PUT_BYTE(ap, buf, c, islcp)	do {		\
 	if ((islcp && c < 0x20) || (ap->xaccm[c >> 5] & (1 << (c & 0x1f)))) {\
 		*buf++ = PPP_ESCAPE;			\
-		*buf++ = c ^ 0x20;			\
+		*buf++ = c ^ PPP_TRANS;			\
 	} else						\
 		*buf++ = c;				\
 } while (0)
@@ -897,7 +897,7 @@ ppp_async_input(struct asyncppp *ap, const unsigned char *buf,
 				sp = skb_put(skb, n);
 				memcpy(sp, buf, n);
 				if (ap->state & SC_ESCAPE) {
-					sp[0] ^= 0x20;
+					sp[0] ^= PPP_TRANS;
 					ap->state &= ~SC_ESCAPE;
 				}
 			}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ppp: use PPP_TRANS instead of the magic number 0x20
  2011-06-15  7:58 [PATCH] ppp: use PPP_TRANS instead of the magic number 0x20 Changli Gao
@ 2011-06-17  3:44 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-06-17  3:44 UTC (permalink / raw)
  To: xiaosuo; +Cc: paulus, linux-ppp, netdev

From: Changli Gao <xiaosuo@gmail.com>
Date: Wed, 15 Jun 2011 15:58:13 +0800

> Signed-off-by: Changli Gao <xiaosuo@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-17  3:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15  7:58 [PATCH] ppp: use PPP_TRANS instead of the magic number 0x20 Changli Gao
2011-06-17  3:44 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).