From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Eugene Teo <eugeneteo@kernel.sg>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru,
netdev@vger.kernel.org, security@kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [Security] inet_diag insufficient validation?
Date: Wed, 15 Jun 2011 10:35:24 -0400 [thread overview]
Message-ID: <1308148524.3718.0.camel@dan> (raw)
In-Reply-To: <BANLkTin9fqYSxq4ne5hV_ri-zKeMZ9mE_g@mail.gmail.com>
On Fri, 2011-06-03 at 14:55 +0800, Eugene Teo wrote:
> Cc'ed acme.
>
> On Wed, Jun 1, 2011 at 11:40 PM, Dan Rosenberg <drosenberg@vsecurity.com> wrote:
> > It seems to me that the auditing performed by inet_diag_bc_audit() is
> > insufficient to prevent pathological INET_DIAG bytecode from doing bad
> > things.
> >
> > Firstly, it's possible to cause an infinite loop in inet_diag_bc_audit()
> > with a INET_DIAG_BC_JMP opcode with a "yes" value of 0. The valid_cc()
> > function, also called from here, seems suspicious as well.
> >
Any chance of getting this fixed? I have a reproducer available if
necessary.
-Dan
next prev parent reply other threads:[~2011-06-15 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 15:40 inet_diag insufficient validation? Dan Rosenberg
2011-06-01 15:50 ` Dan Rosenberg
2011-06-03 0:50 ` Dan Rosenberg
2011-06-03 6:55 ` [Security] " Eugene Teo
2011-06-15 14:35 ` Dan Rosenberg [this message]
2011-06-17 20:19 ` [PATCH] inet_diag: fix inet_diag_bc_audit() Eric Dumazet
2011-06-17 20:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308148524.3718.0.camel@dan \
--to=drosenberg@vsecurity.com \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=eugeneteo@kernel.sg \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).