From: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.hengli.com.au, shemminger@vyatta.com,
netdev@vger.kernel.org, kakuta.hayato@oss.ntt.co.jp
Subject: Re: [PATCH 1/2] IGMP snooping: set mrouters_only flag for IPv4 traffic properly
Date: Fri, 17 Jun 2011 13:39:01 +0900 [thread overview]
Message-ID: <1308285541.3761.7.camel@nausicaa> (raw)
In-Reply-To: <20110616.231447.1625738654020726451.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
> Date: Tue, 14 Jun 2011 10:04:43 +0900
>
> > Upon reception of a IGMP/IGMPv2 membership report the kernel sets the
> > mrouters_only flag in a skb that may be a clone of the original skb, which
> > means that sometimes the bridge loses track of membership report packets (cb
> > buffers are tied to a specific skb and not shared) and it ends up forwading
> > join requests to the bridge interface.
> >
> > This can cause unexpected membership timeouts and intermitent/permanent loss
> > of connectivity as described in RFC 4541 [2.1.1. IGMP Forwarding Rules]:
> >
> > A snooping switch should forward IGMP Membership Reports only to
> > those ports where multicast routers are attached.
> > [...]
> > Sending membership reports to other hosts can result, for IGMPv1
> > and IGMPv2, in unintentionally preventing a host from joining a
> > specific multicast group.
> >
> >
> > Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> > Tested-by: Hayato Kakuta <kakuta.hayato@oss.ntt.co.jp>
>
> Applied.
Thank you David.
By the way, What kernel version(s) are you targeting for these two
patches. It would be great if we could get them upstream before 3.0
comes out. Without this fix the IGMP snooping code is simply unusable in
certain configurations.
- Fernando
next prev parent reply other threads:[~2011-06-17 4:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 2:59 [PATCH 0/2] IGMP snooping: set mrouters_only flag properly Fernando Luis Vazquez Cao
2011-06-13 3:02 ` IGMP snooping: set mrouters_only flag for IPv4 traffic properly Fernando Luis Vazquez Cao
2011-06-14 17:22 ` Stephen Hemminger
2011-06-15 5:09 ` Fernando Luis Vázquez Cao
2011-06-13 3:21 ` [PATCH 2/2] IGMP snooping: set mrouters_only flag for IPv6 " Fernando Luis Vazquez Cao
2011-06-14 1:01 ` [PATCH 0/2] IGMP snooping: set mrouters_only flag properly Fernando Luis Vázquez Cao
2011-06-14 1:04 ` [PATCH 1/2] IGMP snooping: set mrouters_only flag for IPv4 traffic properly Fernando Luis Vázquez Cao
2011-06-17 3:14 ` David Miller
2011-06-17 4:39 ` Fernando Luis Vazquez Cao [this message]
2011-06-14 1:06 ` [PATCH 2/2] IGMP snooping: set mrouters_only flag for IPv6 " Fernando Luis Vázquez Cao
2011-06-17 3:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308285541.3761.7.camel@nausicaa \
--to=fernando@oss.ntt.co.jp \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kakuta.hayato@oss.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).