From: Ben Hutchings <bhutchings@solarflare.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 1/2] net: Support getting/setting RX-FCS in drivers.
Date: Fri, 17 Jun 2011 17:00:34 +0100 [thread overview]
Message-ID: <1308326434.2831.16.camel@bwh-desktop> (raw)
In-Reply-To: <4DFB73B2.10506@candelatech.com>
On Fri, 2011-06-17 at 08:33 -0700, Ben Greear wrote:
> On 06/17/2011 05:20 AM, Ben Hutchings wrote:
> > On Thu, 2011-06-16 at 21:30 -0700, greearb@candelatech.com wrote:
> >> From: Ben Greear<greearb@candelatech.com>
> >>
> >> This will allow us to enable/disable having the Ethernet
> >> frame checksum appended to the skb. Enabling this is
> >> useful when sniffing packets.
> >>
> >> In particular, this can be used to test logic that allows
> >> a NIC to receive all frames, even ones with bad checksums.
[...]
> > And as Michal says, this could reasonably be a feature not an entirely
> > separate flag. I'm not sure it's that important to have debugging flags
> > in features, but I also don't want to have 2 commands per flag...
>
> I'm not sure it really counts as a feature, and I've no desire to tangle
> with the effort to extend features beyond 32 bits.
There are several people wanting to add new flags, so between you I'm
sure you can manage it.
> Maybe we could have a new
> ethtool command that took a struct with two args, so we can "set flag-foo val"
> instead of 'enable-flag-foo' and 'disable-flag-foo'?
>
> That should be only one additional method for the drivers to implement, and
> can be used for the other patches I have planned as well.
Whereas implementing an extra feature toggle now requires zero extra
methods.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-17 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 4:30 [RFC 0/2] Allow NICs to pass Frame Checksum up the stack greearb
2011-06-17 4:30 ` [RFC 1/2] net: Support getting/setting RX-FCS in drivers greearb
2011-06-17 7:36 ` Michał Mirosław
2011-06-17 12:20 ` Ben Hutchings
2011-06-17 15:33 ` Ben Greear
2011-06-17 16:00 ` Ben Hutchings [this message]
2011-06-17 4:30 ` [RFC 2/2] e100: Support receiving Ethernet FCS greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308326434.2831.16.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).