From: Ben Hutchings <bhutchings@solarflare.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Hayes Wang <hayeswang@realtek.com>,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH net-next 3/4] r8169: support new firmware format.
Date: Fri, 17 Jun 2011 22:15:08 +0100 [thread overview]
Message-ID: <1308345308.2831.33.camel@bwh-desktop> (raw)
In-Reply-To: <20110617193133.GC2287@electric-eye.fr.zoreil.com>
On Fri, 2011-06-17 at 21:31 +0200, Francois Romieu wrote:
> The new firmware format adds versioning as firmware for a specific
> chipset appears to be subject to change. Current "legacy" format is
> still supported.
[...]
> static bool rtl_fw_format_ok(struct rtl8169_private *tp, struct rtl_fw *rtl_fw)
> {
[...]
> - if (!(fw->size % FW_OPCODE_SIZE)) {
> + if (fw->size < FW_OPCODE_SIZE)
> + goto out;
[...]
> + if (fw->size % FW_OPCODE_SIZE)
> + goto out;
> +
[...]
> -
> +out:
> return rc;
> }
These changes belong in patch 2/4.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-17 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 19:28 [PATCH net-next 0/4] Pull request for 'davem-next.r8169' branch Francois Romieu
2011-06-17 19:30 ` [PATCH net-next 1/4] r8169: move the firmware down into the device private data Francois Romieu
2011-06-17 19:31 ` [PATCH net-next 2/4] r8169: explicit firmware format check Francois Romieu
2011-06-17 21:13 ` Ben Hutchings
2011-06-17 22:11 ` Francois Romieu
2011-06-17 21:16 ` Ben Hutchings
2011-06-17 19:31 ` [PATCH net-next 3/4] r8169: support new firmware format Francois Romieu
2011-06-17 21:15 ` Ben Hutchings [this message]
2011-06-17 19:32 ` [PATCH net-next 4/4] r8169: check firmware content sooner Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308345308.2831.33.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).