From: Ben Hutchings <bhutchings@solarflare.com>
To: jeffrey.t.kirsher@intel.com
Cc: Joe Perches <joe@perches.com>, netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [RFC] Moving files around in drivers/net
Date: Mon, 20 Jun 2011 04:22:12 +0100 [thread overview]
Message-ID: <1308540132.11457.97.camel@localhost> (raw)
In-Reply-To: <1308536729.22851.42.camel@jtkirshe-mobl>
On Sun, 2011-06-19 at 19:25 -0700, Jeff Kirsher wrote:
> On Wed, 2011-06-15 at 18:10 -0700, Joe Perches wrote:
[...]
> > Some manufacturer directories are directly populated
> > with multiple drivers, some have subdirectories.
> > Should one style be consistently used?
>
> This is a grey area. I think it makes more sense to group drivers
> either by company, maintainer, bus or commonly used header. It has been
> expressed by others in the community and while placing drivers in
> driver/net/ethernet/<company name> is nice way to organize, companies
> get bought and sold and driver ownership moves from one company to
> another. To constantly rename directories based on the ownership may
> cause un-necessary flux in the directory structure. I tried to tried to
> avoid using company names unless I was confident about it.
You could try to futureproof by leaving out companies altogether and
just considering the technical heritage of hardware. For example, the
netxen and qlcnic drivers appear to work with related hardware, but qlge
and qlcnic do not. But this is possibly not a lot more objective than
what you've done so far, and it doesn't make it any easier to name the
directories.
> Some of the suggestions you listed below seem fine, especially since
> several of these companies have been around for some time and actively
> maintain their driver(s).
[...]
> > sfc may be solarflare
[...]
This directory only contains a single net driver, and its name matches
the prefix for Solarflare controller part numbers (not LOMs, but the
driver doesn't care about the distinction). Any separate driver for
future Solarflare hardware is also likely to be named beginning with the
letters 'sfc'. So I'd be happier if this was *not* renamed.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-20 3:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 19:30 [RFC] Moving files around in drivers/net Joe Perches
2011-06-01 19:53 ` Jeff Kirsher
2011-06-01 20:01 ` Joe Perches
2011-06-15 18:38 ` Jeff Kirsher
2011-06-15 20:35 ` Andy Gospodarek
2011-06-16 1:10 ` Joe Perches
2011-06-16 3:34 ` Po-Yu Chuang
2011-06-20 1:42 ` Jeff Kirsher
2011-06-16 5:05 ` Sathya.Perla
2011-06-20 1:48 ` Jeff Kirsher
2011-06-16 14:14 ` Jon Mason
2011-06-20 1:51 ` Jeff Kirsher
2011-06-16 15:03 ` Jon Mason
2011-06-20 1:59 ` Jeff Kirsher
2011-06-20 15:23 ` Jon Mason
2011-06-23 13:30 ` Giuseppe CAVALLARO
2011-06-24 3:56 ` Jeff Kirsher
2011-06-20 2:25 ` Jeff Kirsher
2011-06-20 3:22 ` Ben Hutchings [this message]
2011-06-20 4:02 ` Jeff Kirsher
2011-06-20 5:23 ` Jan Engelhardt
2011-06-20 6:01 ` Joe Perches
2011-06-01 21:07 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308540132.11457.97.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jengelh@medozas.de \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).