Re: [RFC] Moving files around in drivers/net

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]

On Sun, 2011-06-19 at 20:22 -0700, Ben Hutchings wrote:
> On Sun, 2011-06-19 at 19:25 -0700, Jeff Kirsher wrote:
> > On Wed, 2011-06-15 at 18:10 -0700, Joe Perches wrote:
> [...]
> > > Some manufacturer directories are directly populated
> > > with multiple drivers, some have subdirectories.
> > > Should one style be consistently used?
> > 
> > This is a grey area.  I think it makes more sense to group drivers
> > either by company, maintainer, bus or commonly used header.  It has been
> > expressed by others in the community and while placing drivers in
> > driver/net/ethernet/<company name> is nice way to organize, companies
> > get bought and sold and driver ownership moves from one company to
> > another.  To constantly rename directories based on the ownership may
> > cause un-necessary flux in the directory structure.  I tried to tried to
> > avoid using company names unless I was confident about it.
> 
> You could try to futureproof by leaving out companies altogether and
> just considering the technical heritage of hardware.  For example, the
> netxen and qlcnic drivers appear to work with related hardware, but qlge
> and qlcnic do not.  But this is possibly not a lot more objective than
> what you've done so far, and it doesn't make it any easier to name the
> directories.
> 
> > Some of the suggestions you listed below seem fine, especially since
> > several of these companies have been around for some time and actively
> > maintain their driver(s).
> [...]
> > > sfc may be solarflare
> [...]
> 
> This directory only contains a single net driver, and its name matches
> the prefix for Solarflare controller part numbers (not LOMs, but the
> driver doesn't care about the distinction).  Any separate driver for
> future Solarflare hardware is also likely to be named beginning with the
> letters 'sfc'.  So I'd be happier if this was *not* renamed.
> 
> Ben.
> 

Thanks Ben, I will keep it sfc.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]