Re: [net-next 04/17] ixgbevf: provide 64 bit statistics

[Eric Dumazet <eric.dumazet@gmail.com>]

Le dimanche 19 juin 2011 à 17:58 -0700, Jeff Kirsher a écrit :
> From: Stephen Hemminger <shemminger@vyatta.com>
> 
> Compute statistics per ring using 64 bits, and provide
> network device stats in 64 bits.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Greg Rose <Gregory.v.rose@intel.com>
> Tested-by: Evan Swanson <evan.swanson@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---

>  
> +static struct rtnl_link_stats64 *ixgbevf_get_stats(struct net_device *netdev,
> +						   struct rtnl_link_stats64 *stats)
> +{
> +	struct ixgbevf_adapter *adapter = netdev_priv(netdev);
> +	int i;
> +
> +	ixgbevf_update_stats(adapter);
> +
> +	stats->multicast = adapter->stats.vfmprc - adapter->stats.base_vfmprc;
> +
> +	for (i = 0; i < adapter->num_rx_queues; i++) {
> +		stats->rx_bytes += adapter->rx_ring[i].total_bytes;
> +		stats->rx_packets += adapter->rx_ring[i].total_packets;
> +	}
> +
> +	for (i = 0; i < adapter->num_tx_queues; i++) {
> +		stats->tx_bytes += adapter->tx_ring[i].total_bytes;
> +		stats->tx_packets += adapter->tx_ring[i].total_packets;
> +	}
> +
> +	return stats;
> +}
> +

Unfortunately this patch is racy on 32bit arches.

Jeff, maybe you missed all the discussion we had lately on these
conversions, needing appropriate synchronization ?

It seems a lot of bugs were added lately with Stephen patches, this is
rather unfortunate...

I guess I'll have to review them and send fixes.