* Re: [Bugme-new] [Bug 37992] New: It's not possible to compile kernel if CONFIG_NETCONSOLE_DYNAMIC is turned on [not found] <bug-37992-10286@https.bugzilla.kernel.org/> @ 2011-06-20 19:28 ` Andrew Morton 2011-06-21 4:25 ` [PATCH] netconsole: fix build when " Randy Dunlap 0 siblings, 1 reply; 8+ messages in thread From: Andrew Morton @ 2011-06-20 19:28 UTC (permalink / raw) To: netdev; +Cc: bugme-daemon, hilld (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Mon, 20 Jun 2011 19:09:49 GMT bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=37992 > > Summary: It's not possible to compile kernel if > CONFIG_NETCONSOLE_DYNAMIC is turned on > Product: Drivers > Version: 2.5 > Kernel Version: 3.0-rc3+ > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: high > Priority: P1 > Component: Network > AssignedTo: drivers_network@kernel-bugs.osdl.org > ReportedBy: hilld@binarystorm.net > Regression: No > > > Hello guys, > > It's not possible to compile kernel if CONFIG_NETCONSOLE_DYNAMIC is turned > on ... > > drivers/built-in.o: In function `netconsole_target_put': > /usr/src/linux-3.0/drivers/net/netconsole.c:133: undefined reference to > `config_item_put' > drivers/built-in.o: In function `netconsole_target_get': > /usr/src/linux-3.0/drivers/net/netconsole.c:127: undefined reference to > `config_item_get' > drivers/built-in.o: In function `netconsole_target_put': > /usr/src/linux-3.0/drivers/net/netconsole.c:133: undefined reference to > `config_item_put' > drivers/built-in.o: In function `netconsole_target_get': > /usr/src/linux-3.0/drivers/net/netconsole.c:127: undefined reference to > `config_item_get' > drivers/built-in.o: In function `netconsole_target_put': > /usr/src/linux-3.0/drivers/net/netconsole.c:133: undefined reference to > `config_item_put' > drivers/built-in.o: In function `drop_netconsole_target': > /usr/src/linux-3.0/drivers/net/netconsole.c:588: undefined reference to > `config_item_put' > drivers/built-in.o: In function `make_netconsole_target': > /usr/src/linux-3.0/drivers/net/netconsole.c:561: undefined reference to > `config_item_init_type_name' > drivers/built-in.o: In function `dynamic_netconsole_init': > /usr/src/linux-3.0/drivers/net/netconsole.c:109: undefined reference to > `config_group_init' > /usr/src/linux-3.0/drivers/net/netconsole.c:111: undefined reference to > `configfs_register_subsystem' > drivers/built-in.o: In function `dynamic_netconsole_exit': > /usr/src/linux-3.0/drivers/net/netconsole.c:116: undefined reference to > `configfs_unregister_subsystem' > make: *** [.tmp_vmlinux1] Error 1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-20 19:28 ` [Bugme-new] [Bug 37992] New: It's not possible to compile kernel if CONFIG_NETCONSOLE_DYNAMIC is turned on Andrew Morton @ 2011-06-21 4:25 ` Randy Dunlap 2011-06-21 12:45 ` Ben Hutchings 2011-06-21 12:50 ` [PATCH] " WANG Cong 0 siblings, 2 replies; 8+ messages in thread From: Randy Dunlap @ 2011-06-21 4:25 UTC (permalink / raw) To: Andrew Morton, davem; +Cc: netdev, bugme-daemon, hilld From: Randy Dunlap <randy.dunlap@oracle.com> When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors in netconsole: drivers/built-in.o: In function `drop_netconsole_target': netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' drivers/built-in.o: In function `make_netconsole_target': netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name' drivers/built-in.o: In function `write_msg': netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get' netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put' drivers/built-in.o: In function `netconsole_netdev_event': netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put' netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get' netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put' drivers/built-in.o: In function `init_netconsole': netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init' netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem' drivers/built-in.o: In function `dynamic_netconsole_exit': netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem' so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build errors. This is one possible fix. Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992 Reported-by: David Hill <hilld@binarystorm.net> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lnx-30-rc3.orig/drivers/net/Kconfig +++ lnx-30-rc3/drivers/net/Kconfig @@ -3416,7 +3416,7 @@ config NETCONSOLE config NETCONSOLE_DYNAMIC bool "Dynamic reconfiguration of logging targets" - depends on NETCONSOLE && SYSFS && CONFIGFS_FS + depends on NETCONSOLE && SYSFS && CONFIGFS_FS=y help This option enables the ability to dynamically reconfigure target parameters (interface, IP addresses, port numbers, MAC addresses) ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-21 4:25 ` [PATCH] netconsole: fix build when " Randy Dunlap @ 2011-06-21 12:45 ` Ben Hutchings 2011-06-21 14:05 ` Randy Dunlap 2011-06-21 18:01 ` [PATCH v2] " Randy Dunlap 2011-06-21 12:50 ` [PATCH] " WANG Cong 1 sibling, 2 replies; 8+ messages in thread From: Ben Hutchings @ 2011-06-21 12:45 UTC (permalink / raw) To: Randy Dunlap; +Cc: Andrew Morton, davem, netdev, bugme-daemon, hilld On Mon, 2011-06-20 at 21:25 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors > in netconsole: > > drivers/built-in.o: In function `drop_netconsole_target': > netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' > drivers/built-in.o: In function `make_netconsole_target': > netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name' > drivers/built-in.o: In function `write_msg': > netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get' > netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put' > drivers/built-in.o: In function `netconsole_netdev_event': > netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put' > netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get' > netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put' > drivers/built-in.o: In function `init_netconsole': > netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init' > netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem' > drivers/built-in.o: In function `dynamic_netconsole_exit': > netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem' > > so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build errors. [...] NETCONSOLE is tristate, and I think NETCONSOLE=m && NETCONSOLE_DYNAMIC=y && CONFIGFS_FS=m should be OK. It seems like Kconfig should have a '>=' operator which behaves like a numeric comparison with n=0, m=1, y=2. Then we could use a dependency of: NETCONSOLE && SYSFS && CONFIGFS_FS>=NETCONSOLE But for now I think the correct dependency is: NETCONSOLE && SYSFS && CONFIGFS_FS && !(NETCONSOLE=y && CONFIGFS_FS=m) Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-21 12:45 ` Ben Hutchings @ 2011-06-21 14:05 ` Randy Dunlap 2011-06-21 18:01 ` [PATCH v2] " Randy Dunlap 1 sibling, 0 replies; 8+ messages in thread From: Randy Dunlap @ 2011-06-21 14:05 UTC (permalink / raw) To: Ben Hutchings; +Cc: Andrew Morton, davem, netdev, bugme-daemon, hilld On 06/21/11 05:45, Ben Hutchings wrote: > On Mon, 2011-06-20 at 21:25 -0700, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors >> in netconsole: >> >> drivers/built-in.o: In function `drop_netconsole_target': >> netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' >> drivers/built-in.o: In function `make_netconsole_target': >> netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name' >> drivers/built-in.o: In function `write_msg': >> netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get' >> netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put' >> drivers/built-in.o: In function `netconsole_netdev_event': >> netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put' >> netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get' >> netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put' >> drivers/built-in.o: In function `init_netconsole': >> netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init' >> netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem' >> drivers/built-in.o: In function `dynamic_netconsole_exit': >> netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem' >> >> so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build errors. > [...] > > NETCONSOLE is tristate, and I think NETCONSOLE=m && NETCONSOLE_DYNAMIC=y > && CONFIGFS_FS=m should be OK. > > It seems like Kconfig should have a '>=' operator which behaves like a > numeric comparison with n=0, m=1, y=2. Then we could use a dependency > of: > NETCONSOLE && SYSFS && CONFIGFS_FS>=NETCONSOLE > > But for now I think the correct dependency is: > NETCONSOLE && SYSFS && CONFIGFS_FS && !(NETCONSOLE=y && CONFIGFS_FS=m) or just have NETCONSOLE_DYNAMIC select CONFIGFS_FS instead of depend on it. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-21 12:45 ` Ben Hutchings 2011-06-21 14:05 ` Randy Dunlap @ 2011-06-21 18:01 ` Randy Dunlap 2011-06-21 23:26 ` David Miller 1 sibling, 1 reply; 8+ messages in thread From: Randy Dunlap @ 2011-06-21 18:01 UTC (permalink / raw) To: Ben Hutchings, Andrew Morton, davem; +Cc: netdev, bugme-daemon, hilld From: Randy Dunlap <randy.dunlap@oracle.com> When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors in netconsole: drivers/built-in.o: In function `drop_netconsole_target': netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' drivers/built-in.o: In function `make_netconsole_target': netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name' drivers/built-in.o: In function `write_msg': netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get' netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put' drivers/built-in.o: In function `netconsole_netdev_event': netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put' netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get' netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put' drivers/built-in.o: In function `init_netconsole': netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init' netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem' drivers/built-in.o: In function `dynamic_netconsole_exit': netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem' so fix the NETCONSOLE_DYNAMIC depends clause to prevent this. Based on email suggestion from Ben Hutchings. Thanks. Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992 Reported-by: David Hill <hilld@binarystorm.net> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- lnx-30-rc3.orig/drivers/net/Kconfig +++ lnx-30-rc3/drivers/net/Kconfig @@ -3416,7 +3416,8 @@ config NETCONSOLE config NETCONSOLE_DYNAMIC bool "Dynamic reconfiguration of logging targets" - depends on NETCONSOLE && SYSFS && CONFIGFS_FS + depends on NETCONSOLE && SYSFS && CONFIGFS_FS && \ + !(NETCONSOLE=y && CONFIGFS_FS=m) help This option enables the ability to dynamically reconfigure target parameters (interface, IP addresses, port numbers, MAC addresses) ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-21 18:01 ` [PATCH v2] " Randy Dunlap @ 2011-06-21 23:26 ` David Miller 0 siblings, 0 replies; 8+ messages in thread From: David Miller @ 2011-06-21 23:26 UTC (permalink / raw) To: randy.dunlap; +Cc: bhutchings, akpm, netdev, bugme-daemon, hilld From: Randy Dunlap <randy.dunlap@oracle.com> Date: Tue, 21 Jun 2011 11:01:20 -0700 > From: Randy Dunlap <randy.dunlap@oracle.com> > > When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors > in netconsole: > > drivers/built-in.o: In function `drop_netconsole_target': > netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' > drivers/built-in.o: In function `make_netconsole_target': > netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name' > drivers/built-in.o: In function `write_msg': > netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get' > netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put' > drivers/built-in.o: In function `netconsole_netdev_event': > netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put' > netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get' > netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put' > drivers/built-in.o: In function `init_netconsole': > netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init' > netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem' > drivers/built-in.o: In function `dynamic_netconsole_exit': > netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem' > > so fix the NETCONSOLE_DYNAMIC depends clause to prevent this. > Based on email suggestion from Ben Hutchings. Thanks. > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992 > > Reported-by: David Hill <hilld@binarystorm.net> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Applied, thanks Randy. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-21 4:25 ` [PATCH] netconsole: fix build when " Randy Dunlap 2011-06-21 12:45 ` Ben Hutchings @ 2011-06-21 12:50 ` WANG Cong 2011-06-21 16:12 ` Randy Dunlap 1 sibling, 1 reply; 8+ messages in thread From: WANG Cong @ 2011-06-21 12:50 UTC (permalink / raw) To: netdev On Mon, 20 Jun 2011 21:25:04 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors in > netconsole: > > drivers/built-in.o: In function `drop_netconsole_target': > netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' > drivers/built-in.o: In function `make_netconsole_target': > netconsole.c:(.text+0x1a10b9): undefined reference to > `config_item_init_type_name' drivers/built-in.o: In function > `write_msg': netconsole.c:(.text+0x1a11a4): undefined reference to > `config_item_get' netconsole.c:(.text+0x1a1211): undefined reference to > `config_item_put' drivers/built-in.o: In function > `netconsole_netdev_event': netconsole.c:(.text+0x1a12cc): undefined > reference to `config_item_put' netconsole.c:(.text+0x1a12ec): undefined > reference to `config_item_get' netconsole.c:(.text+0x1a1366): undefined > reference to `config_item_put' drivers/built-in.o: In function > `init_netconsole': netconsole.c:(.init.text+0x953a): undefined reference > to `config_group_init' netconsole.c:(.init.text+0x9560): undefined > reference to `configfs_register_subsystem' drivers/built-in.o: In > function `dynamic_netconsole_exit': netconsole.c:(.exit.text+0x809): > undefined reference to `configfs_unregister_subsystem' > > so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build > errors. > > This is one possible fix. > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992 > > Reported-by: David Hill <hilld@binarystorm.net> Signed-off-by: Randy > Dunlap <randy.dunlap@oracle.com> --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-30-rc3.orig/drivers/net/Kconfig +++ > lnx-30-rc3/drivers/net/Kconfig > @@ -3416,7 +3416,7 @@ config NETCONSOLE > > config NETCONSOLE_DYNAMIC > bool "Dynamic reconfiguration of logging targets" > - depends on NETCONSOLE && SYSFS && CONFIGFS_FS > + depends on NETCONSOLE > && SYSFS && CONFIGFS_FS=y I recall someone already fixed this by adding "select CONFIGFS_FS", who removed it again... :-/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on 2011-06-21 12:50 ` [PATCH] " WANG Cong @ 2011-06-21 16:12 ` Randy Dunlap 0 siblings, 0 replies; 8+ messages in thread From: Randy Dunlap @ 2011-06-21 16:12 UTC (permalink / raw) To: WANG Cong, Ben Hutchings; +Cc: netdev, Andrew Morton, davem, hilld On Tue, 21 Jun 2011 12:50:14 +0000 (UTC) WANG Cong wrote: > On Mon, 20 Jun 2011 21:25:04 -0700, Randy Dunlap wrote: > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors in > > netconsole: > > > > drivers/built-in.o: In function `drop_netconsole_target': > > netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' > > drivers/built-in.o: In function `make_netconsole_target': > > netconsole.c:(.text+0x1a10b9): undefined reference to > > `config_item_init_type_name' drivers/built-in.o: In function > > `write_msg': netconsole.c:(.text+0x1a11a4): undefined reference to > > `config_item_get' netconsole.c:(.text+0x1a1211): undefined reference to > > `config_item_put' drivers/built-in.o: In function > > `netconsole_netdev_event': netconsole.c:(.text+0x1a12cc): undefined > > reference to `config_item_put' netconsole.c:(.text+0x1a12ec): undefined > > reference to `config_item_get' netconsole.c:(.text+0x1a1366): undefined > > reference to `config_item_put' drivers/built-in.o: In function > > `init_netconsole': netconsole.c:(.init.text+0x953a): undefined reference > > to `config_group_init' netconsole.c:(.init.text+0x9560): undefined > > reference to `configfs_register_subsystem' drivers/built-in.o: In > > function `dynamic_netconsole_exit': netconsole.c:(.exit.text+0x809): > > undefined reference to `configfs_unregister_subsystem' > > > > so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build > > errors. > > > > This is one possible fix. > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992 > > > > Reported-by: David Hill <hilld@binarystorm.net> Signed-off-by: Randy > > Dunlap <randy.dunlap@oracle.com> --- > > drivers/net/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- lnx-30-rc3.orig/drivers/net/Kconfig +++ > > lnx-30-rc3/drivers/net/Kconfig > > @@ -3416,7 +3416,7 @@ config NETCONSOLE > > > > config NETCONSOLE_DYNAMIC > > bool "Dynamic reconfiguration of logging targets" > > - depends on NETCONSOLE && SYSFS && CONFIGFS_FS > > + depends on NETCONSOLE > > && SYSFS && CONFIGFS_FS=y > > I recall someone already fixed this by adding "select CONFIGFS_FS", > who removed it again... :-/ Hi, Thanks for the reminder. I'll try Ben Hutchings' suggestion. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-06-21 23:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-37992-10286@https.bugzilla.kernel.org/>
2011-06-20 19:28 ` [Bugme-new] [Bug 37992] New: It's not possible to compile kernel if CONFIG_NETCONSOLE_DYNAMIC is turned on Andrew Morton
2011-06-21 4:25 ` [PATCH] netconsole: fix build when " Randy Dunlap
2011-06-21 12:45 ` Ben Hutchings
2011-06-21 14:05 ` Randy Dunlap
2011-06-21 18:01 ` [PATCH v2] " Randy Dunlap
2011-06-21 23:26 ` David Miller
2011-06-21 12:50 ` [PATCH] " WANG Cong
2011-06-21 16:12 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).