From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [RFC 5/7] bnx2: use netdev_irqname Date: Tue, 21 Jun 2011 19:42:46 +0100 Message-ID: <1308681766.2743.69.camel@bwh-desktop> References: <20110621170541.309890798@vyatta.com> <20110621170658.788401517@vyatta.com> <1308679911.2743.45.camel@bwh-desktop> <20110621111756.5c7541ba@nehalam.ftrdhcpuser.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail.solarflare.com ([216.237.3.220]:10535 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865Ab1FUSmt (ORCPT ); Tue, 21 Jun 2011 14:42:49 -0400 In-Reply-To: <20110621111756.5c7541ba@nehalam.ftrdhcpuser.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2011-06-21 at 11:17 -0700, Stephen Hemminger wrote: > On Tue, 21 Jun 2011 19:11:51 +0100 > Ben Hutchings wrote: > > > On Tue, 2011-06-21 at 10:05 -0700, Stephen Hemminger wrote: > > > > > Also increase size of irq name to account for longer device names. > > > Original code was broken for full size names. > > [...] > > > > We should define a macro for the maximum netdev IRQ name length. I > > think this would be IFNAMSIZ + 1 + 2 + 1 + 5 (2 characters for queue > > type; up to 5 digits for 16-bit queue index). > > > > Ben. > > > > Probably should put it in the queue structures? Not really, given an IRQ can be related to multiple queues. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.