From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Wyborny, Carolyn" <carolyn.wyborny@intel.com>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Tong Ho <tong.ho@ericsson.com>
Subject: Re: [PATCH RFC] igb: Fix false positive return of igb_get_auto_rd_done for 82580
Date: Tue, 21 Jun 2011 14:17:26 -0700 [thread overview]
Message-ID: <1308691047.22851.60.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1308682969-20690-1-git-send-email-guenter.roeck@ericsson.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Tue, 2011-06-21 at 12:02 -0700, Guenter Roeck wrote:
> From: Tong Ho <tong.ho@ericsson.com>
>
> 82580 re-reads the port specific portion of eeprom after port reset.
> If called immediately after a reset, igb_get_auto_rd_done() returns
> false positive because the done bit has yet to transition from 1 to 0.
>
> Add wrfl() immediately after resetting 82580 port or device,
> plus a 1ms delay, to avoid the problem.
>
> Signed-off-by: Tong Ho <tong.ho@ericsson.com>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Sent as RFC since I am not entirely sure if the solution is the
> correct one
> to address the problem we are seeing. If there is a better solution,
> please
> let me know.
Thank you for the suggested patch. Carolyn is the maintainer for igb
and we will look into this issue you are seeing and the suggested fix.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-06-21 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 19:02 [PATCH RFC] igb: Fix false positive return of igb_get_auto_rd_done for 82580 Guenter Roeck
2011-06-21 21:17 ` Jeff Kirsher [this message]
2011-07-05 14:31 ` Guenter Roeck
2011-07-06 15:28 ` Wyborny, Carolyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308691047.22851.60.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=guenter.roeck@ericsson.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tong.ho@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox