From: Joe Perches <joe@perches.com>
To: Ron Mercer <ron.mercer@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
jitendra.kalsaria@qlogic.com, ameen.rahman@qlogic.com
Subject: Re: [net-2.6 PATCH 2/3] qlge:Fix printk priority so chip fatal errors are always reported.
Date: Thu, 23 Jun 2011 11:50:49 -0700 [thread overview]
Message-ID: <1308855049.6688.19.camel@Joe-Laptop> (raw)
In-Reply-To: <1308851544-25719-2-git-send-email-ron.mercer@qlogic.com>
On Thu, 2011-06-23 at 10:52 -0700, Ron Mercer wrote:
> From: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
> Precedence of the printk should be at higher level so chip
> fatal errors are always reported.
You probably want to use netdev_err then, not a masked
netif_err when it is optionally not reported.
> diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
[]
> @@ -2170,7 +2170,7 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev,
> return;
>
> case CAM_LOOKUP_ERR_EVENT:
> - netif_err(qdev, link, qdev->ndev,
> + netif_err(qdev, drv, qdev->ndev,
> "Multiple CAM hits lookup occurred.\n");
netdev_err(qdev->ndev, "Multiple CAM hits lookup occurred\n");
> @@ -2178,13 +2178,13 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev,
> return;
>
> case SOFT_ECC_ERROR_EVENT:
> - netif_err(qdev, rx_err, qdev->ndev,
> + netif_err(qdev, drv, qdev->ndev,
> "Soft ECC error detected.\n");
netdev_err(qdev->ndev, "Soft ECC error detected\n");
etc...
next prev parent reply other threads:[~2011-06-23 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 17:52 [net-2.6 PATCH 1/3] qlge:Fix crash caused by mailbox execution on wedged chip Ron Mercer
2011-06-23 17:52 ` [net-2.6 PATCH 2/3] qlge:Fix printk priority so chip fatal errors are always reported Ron Mercer
2011-06-23 18:50 ` Joe Perches [this message]
2011-06-23 18:43 ` Ron Mercer
2011-06-30 20:02 ` [net-2.6 PATCH 1/3] qlge:Fix crash caused by mailbox execution on wedged chip Ron Mercer
2011-07-02 0:36 ` David Miller
2011-06-30 20:02 ` [net-2.6 PATCH 2/3] qlge: Fix printk priority so chip fatal errors are always reported Ron Mercer
2011-07-02 0:36 ` David Miller
2011-06-30 20:02 ` [net-2.6 PATCH 3/3] qlge:Version change to v1.00.00.29 Ron Mercer
2011-07-02 0:36 ` David Miller
2011-06-23 17:52 ` Ron Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308855049.6688.19.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ameen.rahman@qlogic.com \
--cc=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox