From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net,
Alexander Duyck <alexander.h.duyck@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com
Subject: Re: [net-next 02/11] ixgbe: fix flags relating to perfect filters to support coexistence
Date: Thu, 23 Jun 2011 23:40:41 -0700 [thread overview]
Message-ID: <1308897641.11000.11.camel@Joe-Laptop> (raw)
In-Reply-To: <1308895397-23133-3-git-send-email-jeffrey.t.kirsher@intel.com>
On Thu, 2011-06-23 at 23:03 -0700, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> diff --git a/drivers/net/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ixgbe/ixgbe_dcb_nl.c
[]
> @@ -114,11 +114,12 @@ static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state)
> u8 err = 0;
> struct ixgbe_adapter *adapter = netdev_priv(netdev);
>
> + /* verify there is something to do, if not then exit */
> + if (!!state != !(adapter->flags & IXGBE_FLAG_DCB_ENABLED))
> + return err;
That's a bit hard to read. Maybe this is clearer?
if (!!state == !!(adapter->flags & IXGBE_FLAG_DCG_ENABLED))
next prev parent reply other threads:[~2011-06-24 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 6:03 [net-next 00/11][pull request] Intel Wired LAN Driver Update Jeff Kirsher
2011-06-24 6:03 ` [net-next 01/11] ixgbe: remove ntuple filtering Jeff Kirsher
2011-06-24 6:03 ` [net-next 02/11] ixgbe: fix flags relating to perfect filters to support coexistence Jeff Kirsher
2011-06-24 6:40 ` Joe Perches [this message]
2011-06-24 6:03 ` [net-next 03/11] ixgbe: update perfect filter framework to support retaining filters Jeff Kirsher
2011-06-24 6:40 ` Joe Perches
2011-06-24 6:03 ` [net-next 04/11] ixgbe: add basic support for setting and getting nfc controls Jeff Kirsher
2011-06-24 6:03 ` [net-next 05/11] ixgbe: add support for displaying ntuple filters via the nfc interface Jeff Kirsher
2011-06-24 6:03 ` [net-next 06/11] ixgbe: add support for nfc addition and removal of filters Jeff Kirsher
2011-06-24 6:03 ` [net-next 07/11] ixgbe: move setting RSC into a separate function Jeff Kirsher
2011-06-24 6:03 ` [net-next 08/11] ixgbe: move reset code " Jeff Kirsher
2011-06-24 6:03 ` [net-next 09/11] ixgbe: disable RSC when Rx checksum is off Jeff Kirsher
2011-06-24 6:03 ` [net-next 10/11] ixgbe: fix ring assignment issues for SR-IOV and drop cases Jeff Kirsher
2011-06-24 6:03 ` [net-next 11/11] ixgbe: update driver version string Jeff Kirsher
2011-06-24 6:52 ` [net-next 00/11][pull request] Intel Wired LAN Driver Update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308897641.11000.11.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox