* [PATCH V3 1/1] DSA: Enable cascading in multi-chip 6131 configuration
@ 2011-06-25 5:53 Barry Grussling
2011-06-29 12:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Barry Grussling @ 2011-06-25 5:53 UTC (permalink / raw)
To: netdev; +Cc: buytenh, Barry Grussling
From: Barry Grussling <barry@grussling.com>
This patch enables the 6131 family of chips to forward DSA
packets to other switch chips. This is needed if multiple
DSA chips are used in a device. Without this patch the
chip will drop any DSA packets not destined for it.
This patch only enables the forwarding of DSA packets if
multiple chips are used in the switch configuration.
Signed-off-by: Barry Grussling <barry@grussling.com>
---
diff --git a/net/dsa/mv88e6131.c b/net/dsa/mv88e6131.c
index 45f7411..9bd1061 100644
--- a/net/dsa/mv88e6131.c
+++ b/net/dsa/mv88e6131.c
@@ -118,10 +118,14 @@ static int mv88e6131_setup_global(struct dsa_switch *ds)
REG_WRITE(REG_GLOBAL, 0x1a, (dsa_upstream_port(ds) * 0x1100) | 0x00f0);
/*
- * Disable cascade port functionality, and set the switch's
+ * Disable cascade port functionality unless this device
+ * is used in a cascade configuration, and set the switch's
* DSA device number.
*/
- REG_WRITE(REG_GLOBAL, 0x1c, 0xe000 | (ds->index & 0x1f));
+ if (ds->dst->pd->nr_chips > 1)
+ REG_WRITE(REG_GLOBAL, 0x1c, 0xf000 | (ds->index & 0x1f));
+ else
+ REG_WRITE(REG_GLOBAL, 0x1c, 0xe000 | (ds->index & 0x1f));
/*
* Send all frames with destination addresses matching
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3 1/1] DSA: Enable cascading in multi-chip 6131 configuration
2011-06-25 5:53 [PATCH V3 1/1] DSA: Enable cascading in multi-chip 6131 configuration Barry Grussling
@ 2011-06-29 12:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-06-29 12:54 UTC (permalink / raw)
To: barry; +Cc: netdev, buytenh
From: Barry Grussling <barry@grussling.com>
Date: Fri, 24 Jun 2011 22:53:51 -0700
> From: Barry Grussling <barry@grussling.com>
>
> This patch enables the 6131 family of chips to forward DSA
> packets to other switch chips. This is needed if multiple
> DSA chips are used in a device. Without this patch the
> chip will drop any DSA packets not destined for it.
>
> This patch only enables the forwarding of DSA packets if
> multiple chips are used in the switch configuration.
>
> Signed-off-by: Barry Grussling <barry@grussling.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-29 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-25 5:53 [PATCH V3 1/1] DSA: Enable cascading in multi-chip 6131 configuration Barry Grussling
2011-06-29 12:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).