From: jamal <hadi@cyberus.ca>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net_sched: fix dequeuer fairness
Date: Sun, 26 Jun 2011 12:13:46 -0400 [thread overview]
Message-ID: <1309104826.5134.46.camel@mojatatu> (raw)
In-Reply-To: <1309103630.2532.42.camel@edumazet-laptop>
On Sun, 2011-06-26 at 17:53 +0200, Eric Dumazet wrote:
>
> This is because of commit 24f8b2385e03a4f.
>
> Prior to this, we could exit very fast from this function, even after
> receiving a single packet.
>
> jiffies break is kind of lazy, IMHO ;)
And subjective to the value of Hz.
In the case of net_rx_action it seems that we need
"something" other than packet budget to get us out of there
in extreme case when we loop and none of the netdevs have anything
to offer.
In the other extreme it would be very unfair to yield because
of jiffies when budget is not exhausted and devices have something
to offer.
One approach could be to deduct their napi weight when they
return a 0 for work done.
cheers,
jamal
next prev parent reply other threads:[~2011-06-26 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 14:07 [PATCH] net_sched: fix dequeuer fairness jamal
2011-06-26 14:17 ` jamal
2011-06-26 14:53 ` Ben Hutchings
2011-06-26 15:27 ` jamal
2011-06-26 15:09 ` Eric Dumazet
2011-06-26 15:32 ` jamal
2011-06-26 15:53 ` Eric Dumazet
2011-06-26 16:13 ` jamal [this message]
2011-06-26 16:03 ` jamal
2011-06-26 16:26 ` Eric Dumazet
2011-06-26 16:29 ` jamal
2011-06-26 21:18 ` Ben Hutchings
2011-06-26 16:38 ` jamal
2011-06-26 18:13 ` jamal
2011-06-27 7:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309104826.5134.46.camel@mojatatu \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).