From: Joe Perches <joe@perches.com>
To: Jon Mason <mason@myri.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Andrew Gallatin <gallatin@myri.com>
Subject: Re: [PATCH 7/9] myri10ge: misc style cleanups
Date: Mon, 27 Jun 2011 09:05:59 -0700 [thread overview]
Message-ID: <1309190759.3344.10.camel@Joe-Laptop> (raw)
In-Reply-To: <1309187108-12715-7-git-send-email-mason@myri.com>
On Mon, 2011-06-27 at 10:05 -0500, Jon Mason wrote:
> Miscellaneous white space, style, and other cleanups
[]
> diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
[]
> @@ -1538,9 +1538,10 @@ static inline void myri10ge_check_statblock(struct myri10ge_priv *mgp)
> } else {
> if (netif_msg_link(mgp))
> netdev_info(mgp->dev, "link %s\n",
> - link_up == MXGEFW_LINK_MYRINET ?
> - "mismatch (Myrinet detected)" :
> - "down");
> + (link_up ==
> + MXGEFW_LINK_MYRINET ?
> + "mismatch (Myrinet detected)"
> + : "down"));
This could be:
netif_info(mgp, link, mgp->dev, "link %s\n"
link_up == MXGEFW_LINK_MYRINET ?
"mismatch (Myrinet detected)" :
"down");
next prev parent reply other threads:[~2011-06-27 16:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 15:05 [PATCH 1/9] myri10ge: ensure tx queues remain stopped Jon Mason
2011-06-27 15:05 ` [PATCH 2/9] myri10ge: Mask PCI Surprise Link Down Events Jon Mason
2011-06-29 13:02 ` David Miller
2011-06-27 15:05 ` [PATCH 3/9] myri10ge: rework parity error check and cleanup Jon Mason
2011-06-27 15:27 ` Ben Hutchings
2011-06-27 20:26 ` Jon Mason
2011-06-27 16:01 ` Joe Perches
2011-06-27 20:54 ` [PATCH 3/9 v2] " Jon Mason
2011-06-28 2:17 ` Joe Perches
2011-06-28 3:31 ` Jon Mason
2011-06-28 3:57 ` [PATCH 3/9 v3] " Jon Mason
2011-06-29 13:02 ` David Miller
2011-06-27 15:05 ` [PATCH 4/9] myri10ge: allow small_bytes = 0 Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 5/9] myri10ge: add support for set_phys_id Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 6/9] myri10ge: remove unnecessary read of PCI_CAP_ID_EXP Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 7/9] myri10ge: misc style cleanups Jon Mason
2011-06-27 16:05 ` Joe Perches [this message]
2011-06-27 20:56 ` [PATCH 7/9 v2] " Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 8/9] myri10ge: update version Jon Mason
2011-06-29 13:04 ` David Miller
2011-06-27 15:05 ` [PATCH 9/9] myri10ge: Update MAINTAINERS Jon Mason
2011-06-29 13:04 ` David Miller
2011-06-29 13:02 ` [PATCH 1/9] myri10ge: ensure tx queues remain stopped David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309190759.3344.10.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=mason@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox