From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Sathya Perla <sathya.perla@emulex.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6 1/3] be2net: fix netdev_stats_update
Date: Mon, 27 Jun 2011 19:20:41 +0200 [thread overview]
Message-ID: <1309195241.2532.79.camel@edumazet-laptop> (raw)
In-Reply-To: <20110627094337.5108b5f6@nehalam.ftrdhcpuser.net>
Le lundi 27 juin 2011 à 09:43 -0700, Stephen Hemminger a écrit :
> On Mon, 27 Jun 2011 12:10:48 +0530
> Sathya Perla <sathya.perla@emulex.com> wrote:
>
> > Problem initially reproted and fixed by Eric Dumazet <eric.dumazet@gmail.com>
> >
> > netdev_stats_update() resets netdev->stats and then accumulates stats from
> > various rings. This is wrong as stats readers can sometimes catch zero values.
> > Use temporary variables instead for accumulating per-ring values.
> >
> > Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
>
> Should also use u64_stats_sync to ensure correct rollover or 32 bit SMP
> platform.
These are "unsigned long" fields, you dont need u64_stats_sync.
next prev parent reply other threads:[~2011-06-27 17:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 6:40 [PATCH net-next-2.6 1/3] be2net: fix netdev_stats_update Sathya Perla
2011-06-27 6:56 ` Eric Dumazet
2011-06-27 7:07 ` David Miller
2011-06-27 16:43 ` Stephen Hemminger
2011-06-27 17:20 ` Eric Dumazet [this message]
2011-06-27 18:43 ` Stephen Hemminger
2011-06-27 18:43 ` [PATCH net-next] benet: convert to 64 bit stats Stephen Hemminger
2011-06-28 7:37 ` Sathya.Perla
-- strict thread matches above, loose matches on Subject: below --
2011-06-24 8:13 [PATCH net-next-2.6 1/3] be2net: fix netdev_stats_update Sathya Perla
2011-06-24 10:32 ` Eric Dumazet
2011-06-24 8:53 ` Sathya.Perla
2011-06-24 19:59 ` David Miller
2011-06-27 5:19 ` Sathya.Perla
2011-06-27 6:05 ` Eric Dumazet
2011-06-27 6:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309195241.2532.79.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox