From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] net/core: Convert to current logging forms Date: Tue, 28 Jun 2011 21:21:41 +0100 Message-ID: <1309292501.2771.48.camel@bwh-desktop> References: <385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "David S. Miller" , Neil Horman , linux-kernel@vger.kernel.org To: Joe Perches Return-path: Received: from mail.solarflare.com ([216.237.3.220]:10293 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169Ab1F1UVp (ORCPT ); Tue, 28 Jun 2011 16:21:45 -0400 In-Reply-To: <385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2011-06-28 at 12:40 -0700, Joe Perches wrote: > Use pr_fmt, pr_, and netdev_ as appropriate. > > Coalesce long formats. [...] > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -72,6 +72,8 @@ > * - netif_rx() feedback > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + [...] KBUILD_MODNAME is presumably going to be "dev". That's not very meaningful. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.