From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] net/core: Convert to current logging forms Date: Tue, 28 Jun 2011 21:36:56 +0100 Message-ID: <1309293416.2771.50.camel@bwh-desktop> References: <385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com> <1309292501.2771.48.camel@bwh-desktop> <1309293068.29598.14.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "David S. Miller" , Neil Horman , linux-kernel@vger.kernel.org To: Joe Perches Return-path: Received: from mail.solarflare.com ([216.237.3.220]:11921 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973Ab1F1Ug7 (ORCPT ); Tue, 28 Jun 2011 16:36:59 -0400 In-Reply-To: <1309293068.29598.14.camel@Joe-Laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2011-06-28 at 13:31 -0700, Joe Perches wrote: > On Tue, 2011-06-28 at 21:21 +0100, Ben Hutchings wrote: > > On Tue, 2011-06-28 at 12:40 -0700, Joe Perches wrote: > > > Use pr_fmt, pr_, and netdev_ as appropriate. > > > Coalesce long formats. > > [...] > > > --- a/net/core/dev.c > > > +++ b/net/core/dev.c > > > @@ -72,6 +72,8 @@ > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > [...] > > KBUILD_MODNAME is presumably going to be "dev". > > 'tis. > > > That's not very meaningful. > > I think it's not useless though. > > Anything else you think it should be? > Maybe "net_core_device:" or some such like that? "netdev" > Here are the format strings now prefaced by "dev:" > > $ strings net/core/built-in.o |grep "^<.>dev:" > <6>dev: netif_stop_queue() cannot be called before register_netdev() > <4>dev: dev_remove_pack: %p not found > <3>dev: Loading kernel module for a network device with CAP_SYS_MODULE (deprecated) > <0>dev: %s: failed to move %s to init_net: %d > <3>dev: alloc_netdev: Unable to allocate device with zero queues > <3>dev: alloc_netdev: Unable to allocate device with zero RX queues > <3>dev: alloc_netdev: Unable to allocate device Many of these refer to a specific device and should be formatted with one of the netdev_* logging functions. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.