From: maksim.rayskiy@gmail.com
To: netdev@vger.kernel.org
Cc: "Maksim Rayskiy" <mrayskiy@broadcom.com>
Subject: [RFC PATCH] asix: drop rx skb if header length is invalid
Date: Tue, 28 Jun 2011 14:21:31 -0700 [thread overview]
Message-ID: <1309296091-31476-1-git-send-email-maksim.rayskiy@gmail.com> (raw)
From: Maksim Rayskiy <mrayskiy@broadcom.com>
Signed-off-by: Maksim Rayskiy <mrayskiy@broadcom.com>
---
I am using AX88772 usbnet dongle, and sometimes after system resume I am seeing
corrupt rx packets which generate infinite number of
asix_rx_fixup() Bad Header Length
messages.
Looking at asix_rx_fixup() I see that depending on what junk you get in skb you
may end up with never breaking the while loop. Would not it be safer to bail out
as soon as incorrect header length was detected?
drivers/net/usb/asix.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index 6998aa6..9d7a6ec 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -317,6 +317,7 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
if ((short)(header & 0x0000ffff) !=
~((short)((header & 0xffff0000) >> 16))) {
netdev_err(dev->net, "asix_rx_fixup() Bad Header Length\n");
+ return 0;
}
/* get the packet length */
size = (u16) (header & 0x0000ffff);
--
1.7.4.1
reply other threads:[~2011-06-28 21:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309296091-31476-1-git-send-email-maksim.rayskiy@gmail.com \
--to=maksim.rayskiy@gmail.com \
--cc=mrayskiy@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).