From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/core: Convert to current logging forms
Date: Tue, 28 Jun 2011 14:55:40 -0700 [thread overview]
Message-ID: <1309298140.29598.31.camel@Joe-Laptop> (raw)
In-Reply-To: <20110628144923.2bdac9f9@nehalam.ftrdhcpuser.net>
On Tue, 2011-06-28 at 14:49 -0700, Stephen Hemminger wrote:
> Does this actually create useful benefit or just create more bug possibilities?
Probably not the bug possibilities.
It's pretty trivial.
> Those messages are mostly self explanatory as is.
It also has some utility for the cases in drivers
between the alloc_netdev and register_netdev[ice]
where printk/pr_<level> currently has to be used.
Beyond that, (foolish?) consistency only.
cheers, Joe
next prev parent reply other threads:[~2011-06-28 21:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 19:40 [PATCH] net/core: Convert to current logging forms Joe Perches
2011-06-28 20:21 ` Ben Hutchings
2011-06-28 20:31 ` Joe Perches
2011-06-28 20:36 ` Ben Hutchings
2011-06-28 20:40 ` Joe Perches
2011-06-28 21:37 ` Joe Perches
2011-06-28 21:49 ` Stephen Hemminger
2011-06-28 21:55 ` Joe Perches [this message]
2011-06-29 11:11 ` Neil Horman
2011-06-29 11:55 ` David Miller
2011-06-29 15:24 ` Neil Horman
2011-06-29 14:57 ` Joe Perches
2011-06-30 9:55 ` WANG Cong
2011-06-30 17:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309298140.29598.31.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox