From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH] net, wireless: Don't return uninitialized in __cfg80211_stop_sched_scan() Date: Wed, 29 Jun 2011 22:27:24 +0200 Message-ID: <1309379244.4071.7.camel@jlt3.sipsolutions.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , "John W. Linville" , Luciano Coelho To: Jesper Juhl Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, 2011-06-29 at 22:13 +0200, Jesper Juhl wrote: > If the 'driver_initiated' function argument to > __cfg80211_stop_sched_scan() is not 0 then we'll return an > uninitialized 'ret' from the function. 'err'. I also dislike the initialisation, can we just replace the "return err;" at the end of the function with "return 0;" instead? Luca, should it maybe be return -ENOENT anyway in the !sched_scan_req case? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html