From: Joe Perches <joe@perches.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org,
Steffen Klassert <klassert@mathematik.tu-chemnitz.de>,
Santiago Leon <santil@linux.vnet.ibm.com>,
Tim Hockin <thockin@hockin.org>, Don Fry <pcnet32@frontier.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Ion Badulescu <ionut@badula.org>,
Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Grant Grundler <grundler@parisc-linux.org>,
David Dillow <dave@thedillows.org>, Roger Luethi <rl@hellgate.ch>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 00/21] clean up rx_copybreak handling [split version]
Date: Sat, 09 Jul 2011 11:20:32 -0700 [thread overview]
Message-ID: <1310235632.3848.13.camel@Joe-Laptop> (raw)
In-Reply-To: <cover.1310229312.git.mirq-linux@rere.qmqm.pl>
On Sat, 2011-07-09 at 19:17 +0200, Michał Mirosław wrote:
> Split version of rx_copybreak cleanup patch.
Hello Michał.
Looks good, thanks for doing this work.
One style quibble.
You use this style:
+ skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
+ pkt_len, rx_copybreak,
+ &np->pci_dev->dev,
+ le32_to_cpu(desc->frag[0].addr),
+ np->rx_buf_sz);
where almost all other uses throughout drivers/net
align arguments to open parenthesis instead.
+ skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
+ pkt_len, rx_copybreak,
+ &np->pci_dev->dev,
+ le32_to_cpu(desc->frag[0].addr),
+ np->rx_buf_sz);
next prev parent reply other threads:[~2011-07-09 18:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 17:17 [PATCH 00/21] clean up rx_copybreak handling [split version] Michał Mirosław
2011-07-09 17:17 ` [PATCH 06/21] net: ibmveth: make rx_copybreak threshold consistent with other drivers Michał Mirosław
2011-07-09 17:17 ` [PATCH 01/21] net: wrap common patterns of rx handler code Michał Mirosław
2011-07-09 17:17 ` [PATCH 07/21] net: lib82596: use common rx_copybreak handling [strict refill!] Michał Mirosław
2011-07-09 22:25 ` Francois Romieu
2011-07-09 17:17 ` [PATCH 02/21] net: 3c59x: use common rx_copybreak handling Michał Mirosław
2011-07-09 22:22 ` Francois Romieu
2011-07-09 23:23 ` Michał Mirosław
2011-07-10 7:24 ` Francois Romieu
2011-07-09 17:17 ` [PATCH 08/21] net: natsemi: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 03/21] net: epic100: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 04/21] net: fealnx: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 05/21] net: hamachi: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 10/21] net: sgiseeq: use common rx_copybreak handling [strict refill!] Michał Mirosław
2011-07-09 17:17 ` [PATCH 09/21] net: pcnet32: " Michał Mirosław
2011-07-09 22:28 ` Francois Romieu
2011-07-09 17:17 ` [PATCH 14/21] net: tg3: mark bad rx handler behaviour " Michał Mirosław
2011-07-09 17:17 ` [PATCH 11/21] net: sis190: use common rx_copybreak handling Michał Mirosław
2011-07-09 17:17 ` [PATCH 13/21] net: sundance: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 12/21] net: starfire: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 16/21] net: tulip/interrupt.c: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 21/21] net: yellowfin: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 20/21] net: via-velocity: " Michał Mirosław
2011-07-09 22:19 ` Francois Romieu
2011-07-09 17:17 ` [PATCH 15/21] net: tulip/de2104x: use common rx_copybreak handling [strict refill!] Michał Mirosław
2011-07-09 22:31 ` Francois Romieu
2011-07-09 17:17 ` [PATCH 17/21] net: tulip/winbond-840: use common rx_copybreak handling Michał Mirosław
2011-07-09 17:17 ` [PATCH 19/21] net: via-rhine: " Michał Mirosław
2011-07-09 17:17 ` [PATCH 18/21] net: typhoon: " Michał Mirosław
2011-07-09 17:46 ` David Dillow
2011-07-09 18:20 ` Joe Perches [this message]
2011-07-10 11:28 ` [PATCH 00/21] clean up rx_copybreak handling [split version] Michał Mirosław
2011-07-10 11:52 ` Michał Mirosław
2011-07-10 15:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310235632.3848.13.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=ionut@badula.org \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@frontier.com \
--cc=rl@hellgate.ch \
--cc=romieu@fr.zoreil.com \
--cc=santil@linux.vnet.ibm.com \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox