From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eilon Greenstein" Subject: Re: [PATCH v2 46/46] net: mark drivers that drop packets from rx queue head under memory pressure Date: Mon, 11 Jul 2011 09:47:08 +0300 Message-ID: <1310366828.22731.1.camel@lb-tlvb-eilong.il.broadcom.com> References: Reply-To: eilong@broadcom.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "netdev@vger.kernel.org" , "Hartley Sweeten" , "Michael Chan" , "Guo-Fu Tseng" , "Realtek linux nic maintainers" , "Francois Romieu" , "Stephen Hemminger" , "Matthew Carlson" , "Jon Mason" To: =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:3661 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756726Ab1GKGrg convert rfc822-to-8bit (ORCPT ); Mon, 11 Jul 2011 02:47:36 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2011-07-10 at 17:52 -0700, Micha=C5=82 Miros=C5=82aw wrote: > Signed-off-by: Micha=C5=82 Miros=C5=82aw > --- > diff --git a/drivers/net/bnx2x/bnx2x_cmn.c b/drivers/net/bnx2x/bnx2x_= cmn.c > index 4f9164c..a6da01a 100644 > --- a/drivers/net/bnx2x/bnx2x_cmn.c > +++ b/drivers/net/bnx2x/bnx2x_cmn.c > @@ -673,6 +673,9 @@ int bnx2x_rx_int(struct bnx2x_fastpath *fp, int b= udget) > goto reuse_rx; > } > =20 > +#warning drops packets from rx queue head on memory pressure > +#warning (like dev_skb_finish_rx_dma_refill() users) > + We have the dropless_fc module parameter that can be configured if the user prefers pausing on host memory pressure - the problem with that feature is that it is enough that one of the ring runs out of memory an= d the entire port is stopped. When running with 16 rings, this can lead t= o serious throughput degradation - this is why it is kept as a user configurable option. > /* Since we don't have a jumbo ring > * copy small packets if mtu > 1500 > */