From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6 1/2] net: introduce __netdev_alloc_skb_ip_align
Date: Mon, 11 Jul 2011 23:57:08 +0100 [thread overview]
Message-ID: <1310425028.2707.12.camel@bwh-desktop> (raw)
In-Reply-To: <1310421164.2860.21.camel@edumazet-laptop>
On Mon, 2011-07-11 at 23:52 +0200, Eric Dumazet wrote:
> RX rings should use GFP_KERNEL allocations if possible, add
> __netdev_alloc_skb_ip_align() helper to ease this.
[...]
When it is possible, other than when starting an interface? RX refill
normally has to be done in NAPI context or at least synchronised with
NAPI, so GFP_ATOMIC is required. Not sure how much point there is in
making a special case for the initial fill.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-07-11 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 21:52 [PATCH net-next-2.6 1/2] net: introduce __netdev_alloc_skb_ip_align Eric Dumazet
2011-07-11 22:57 ` Ben Hutchings [this message]
2011-07-11 23:12 ` Michał Mirosław
2011-07-12 2:32 ` David Miller
2011-07-12 3:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310425028.2707.12.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).